chrome/android/java/src/org/chromium/chrome/browser/DevToolsServer.java - Issue 17389005: [Android] Abandon bundling DevTools frontends for mobile apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/DevToolsServer.java

Issue 17389005: [Android] Abandon bundling DevTools frontends for mobile apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_devtools_delegate.cc ('k') | chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/DevToolsServer.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/DevToolsServer.java b/chrome/android/java/src/org/chromium/chrome/browser/DevToolsServer.java

index f5777aae5f042130b4a02fe1d39c5e684deb872d..37f943dcfc3b59bbd6b8471001e5bb420a5ab449 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/DevToolsServer.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/DevToolsServer.java

@@ -11,9 +11,8 @@ public class DevToolsServer {

private int mNativeDevToolsServer = 0;

- public DevToolsServer(boolean useBundledFrontendResources,

- String socketName) {

- mNativeDevToolsServer = nativeInitRemoteDebugging(useBundledFrontendResources, socketName);

+ public DevToolsServer(String socketNamePrefix) {

+ mNativeDevToolsServer = nativeInitRemoteDebugging(socketNamePrefix);

}

public void destroy() {

@@ -29,8 +28,7 @@ public class DevToolsServer {

nativeSetRemoteDebuggingEnabled(mNativeDevToolsServer, enabled);

}

- private native int nativeInitRemoteDebugging(boolean useBundledFrontendResources,

- String socketName);

+ private native int nativeInitRemoteDebugging(String socketNamePrefix);

private native void nativeDestroyRemoteDebugging(int devToolsServer);

private native boolean nativeIsRemoteDebuggingEnabled(int devToolsServer);

private native void nativeSetRemoteDebuggingEnabled(int devToolsServer, boolean enabled);