[Android] Abandon bundling DevTools frontends for mobile apps

android_webview/browser/aw_devtools_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_devtools_delegate.h"
 
 #include "android_webview/browser/in_process_view_renderer.h"
 #include "base/bind.h"
 #include "base/json/json_writer.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
-#include "content/public/browser/android/devtools_auth.h"
+#include "components/devtools_remote_frontend/devtools_auth_android.h"
+#include "components/devtools_remote_frontend/devtools_remote_frontend_util.h"
 #include "content/public/browser/devtools_http_handler.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/url_constants.h"
 #include "net/socket/unix_domain_socket_posix.h"
 #include "ui/base/resource/resource_bundle.h"
 
 namespace {
-const char kSocketNameFormat[] = "webview_devtools_remote_%d";
+const char kSocketNameFormat[] = "%s_%d";
 }
 
 namespace android_webview {
 
 AwDevToolsDelegate::AwDevToolsDelegate(content::BrowserContext* browser_context)
     : browser_context_(browser_context) {
+  const std::string socket_name =
+      devtools_remote_frontend::GetDevToolsServerSocketName("webview");

[pfeldman, 2013/06/20 12:37:11]

This only makes sense for android, just hardcode it here.

[mnaganov (inactive), 2013/06/20 16:48:08]

Done.

   devtools_http_handler_ = content::DevToolsHttpHandler::Start(
       new net::UnixDomainSocketWithAbstractNamespaceFactory(
-          base::StringPrintf(kSocketNameFormat, getpid()),
+          base::StringPrintf(kSocketNameFormat,
+                             socket_name.c_str(),
+                             getpid()),
           "",
-          base::Bind(&content::CanUserConnectToDevTools)),
-      "",
+          base::Bind(&devtools_remote_frontend::CanUserConnectToDevTools)),
+      devtools_remote_frontend::GetDevToolsFrontendMainResourceURL(),

[pfeldman, 2013/06/20 12:37:11]

ditto

[mnaganov (inactive), 2013/06/20 16:48:08]

Done.

       this);
 }
 
 AwDevToolsDelegate::~AwDevToolsDelegate() {
 }
 
 void AwDevToolsDelegate::Stop() {
   devtools_http_handler_->Stop();
   // WARNING: |this| has now been deleted by the method above.
 }
@@ skipping 139 matching lines @@
       "      <th style='width:100px; text-align:left;'>Size</th>"
       "    </tr>"
       "    <tbody id='items'></tbody>"
       "  </table>"
       "</body>"
       "</html>";
   return html;
 }
 
 bool AwDevToolsDelegate::BundlesFrontendResources() {
-  return true;
+  return false;
 }
 
 base::FilePath AwDevToolsDelegate::GetDebugFrontendDir() {
   return base::FilePath();
 }
 
 std::string AwDevToolsDelegate::GetPageThumbnailData(const GURL& url) {
   return "";
 }
 
@@ skipping 32 matching lines @@
 }
 
 scoped_refptr<net::StreamListenSocket>
 AwDevToolsDelegate::CreateSocketForTethering(
     net::StreamListenSocket::Delegate* delegate,
     std::string* name) {
   return NULL;
 }
 
 }  // namespace android_webview