Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1738883002: [runtime] Unify comparison operator runtime entries. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Unify comparison operator runtime entries. Only use one set of %StrictEquals/%StrictNotEquals and %Equals/%NotEquals runtime entries for both the interpreter and the old-style CompareICStub. The long-term plan is to update the CompareICStub to also return boolean values, and even allow some more code sharing with the interpreter there. R=mstarzinger@chromium.org Committed: https://crrev.com/55b4df7357557eb16377ad9227e4e0a4224b7885 Cr-Commit-Position: refs/heads/master@{#34303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -127 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +14 lines, -11 lines 0 comments Download
M src/interpreter/interpreter.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +5 lines, -7 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 2 chunks +0 lines, -47 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/runtime/runtime-operators.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +15 lines, -8 lines 0 comments Download
M test/unittests/runtime/runtime-interpreter-unittest.cc View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-25 14:18:30 UTC) #1
Benedikt Meurer
Hey Michi, Here's the baby we discussed earlier. It's just the very first step (I ...
4 years, 10 months ago (2016-02-25 14:20:35 UTC) #2
Michael Starzinger
LGTM. Nice.
4 years, 10 months ago (2016-02-25 14:53:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738883002/1
4 years, 10 months ago (2016-02-25 19:10:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 19:12:30 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 19:12:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55b4df7357557eb16377ad9227e4e0a4224b7885
Cr-Commit-Position: refs/heads/master@{#34303}

Powered by Google App Engine
This is Rietveld 408576698