third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc - Issue 1738843002: Refactoring: Unify WebMemoryAllocatorDump and WebMemoryAllocatorDumpImpl

Unified Diff: third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc

Issue 1738843002: Refactoring: Unify WebMemoryAllocatorDump and WebMemoryAllocatorDumpImpl Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/web_process_memory_dump_impl.h ('k') | third_party/WebKit/Source/platform/web_process_memory_dump_impl_test.cc » ('j') | third_party/WebKit/public/platform/WebMemoryAllocatorDump.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc

diff --git a/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc b/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc

index fabd109230f80118f7fae5062aa679c796f54169..ffd6b1807d894030d81bd24c2e754214cda4ccee 100644

--- a/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc

+++ b/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc

@@ -12,7 +12,7 @@

#include "base/trace_event/process_memory_dump.h"

#include "base/trace_event/trace_event_argument.h"

#include "base/trace_event/trace_event_memory_overhead.h"

-#include "platform/web_memory_allocator_dump_impl.h"

+#include "public/platform/WebMemoryAllocatorDump.h"

#include "skia/ext/skia_trace_memory_dump_impl.h"

namespace blink {

@@ -61,8 +61,8 @@ WebProcessMemoryDumpImpl::createWebMemoryAllocatorDump(

return nullptr;

// Wrap it and return to blink.

- WebMemoryAllocatorDumpImpl* web_memory_allocator_dump_impl =

- new WebMemoryAllocatorDumpImpl(memory_allocator_dump);

+ WebMemoryAllocatorDump* web_memory_allocator_dump_impl =

haraken 2016/02/25 14:38:55 You should use OwnPtr<WebMemoryAllocatorDump>.

hajimehoshi 2016/02/26 11:06:00 I can do this, but memory_allocator_dumps_ takes t

haraken 2016/02/26 11:20:49 The common pattern is: OwnPtr<X> x = adoptPtr(n

hajimehoshi 2016/02/26 12:04:51 Done.

+ new WebMemoryAllocatorDump(memory_allocator_dump);

// memory_allocator_dumps_ will take ownership of

// |web_memory_allocator_dumpd_impl|.