Issue 1738833004: Add file identifiers to summaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1738833004: Add file identifiers to summaries. (Closed)

Created:
4 years, 9 months ago by Paul Berry

Modified:
4 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add file identifiers to summaries. These should make it easier for summary files to interoperate with standard FlatBuffer tools. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7481eff6a88b8a55cce1654ce39a6a8411940fae

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+116 lines, -27 lines)			Patch
M	pkg/analyzer/lib/src/summary/base.dart	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/flat_buffers.dart	View	1 chunk	+11 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/format.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/idl.dart	View	6 chunks	+5 lines, -11 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/flat_buffers_test.dart	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	pkg/analyzer/tool/summary/generate.dart	View	3 chunks	+46 lines, -8 lines	0 comments	Download
M	pkg/analyzer/tool/summary/idl_model.dart	View	1 chunk	+8 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 9 months ago (2016-02-25 18:36:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7481eff6a88b8a55cce1654ce39a6a8411940fae (presubmit successful).