[App Shell] Introduce app_shell.pak

apps/shell/app/shell_main_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/shell/app/shell_main_delegate.h"
 
 #include "apps/shell/browser/shell_content_browser_client.h"
 #include "apps/shell/common/shell_content_client.h"
 #include "apps/shell/renderer/shell_content_renderer_client.h"
 #include "base/command_line.h"
@@ skipping 79 matching lines @@
 
 void ShellMainDelegate::InitializeResourceBundle() {
   ui::ResourceBundle::InitSharedInstanceWithLocale("en-US", NULL);
 
   // The extensions system needs manifest data from the Chrome PAK file.
   // TODO(jamescook): app_shell needs its own manifest data file.
   base::FilePath resources_pack_path;
   PathService::Get(chrome::FILE_RESOURCES_PACK, &resources_pack_path);
   ResourceBundle::GetSharedInstance().AddDataPackFromPath(
       resources_pack_path, ui::SCALE_FACTOR_NONE);
-  // The dev tool needs shell_devtools_discovery_page.html from
-  // content_shell.pak file.
   base::FilePath pak_file, pak_dir;

[tfarina, 2014/02/20 18:46:15]

Please, clean this up.

Like this:

base::FilePath pak_dir;
PathService::Get(base::DIR_MODULE, &pak_dir);
base::FilePath pak_file = pak_dir.AppendASCII("app_shell.pak");
...

you could even inline pak_file directly in AddPackFromPath().

[Haojian Wu, 2014/02/21 05:50:02]

Done.

   PathService::Get(base::DIR_MODULE, &pak_dir);
-  pak_file = pak_dir.Append(FILE_PATH_LITERAL("content_shell.pak"));
+  pak_file = pak_dir.Append(FILE_PATH_LITERAL("app_shell.pak"));
   ResourceBundle::GetSharedInstance().AddDataPackFromPath(
       pak_file, ui::SCALE_FACTOR_NONE);
 }
 
 }  // namespace apps