Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1738823002: [Interpreter] Implement ForInStep directly. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Implement ForInStep directly. The ForInStep bytecode is essentially a (guaranteed) Smi increment operation. We can do not need to go to the runtime for this operation. R=oth@chromium.org Committed: https://crrev.com/40bf2d7eee90c47ca6c8e6cb6098cb11d9bf303b Cr-Commit-Position: refs/heads/master@{#34289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/compiler/code-stub-assembler.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-25 12:17:44 UTC) #1
Benedikt Meurer
Hey Ross, And yet another small one. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-25 12:18:40 UTC) #3
rmcilroy
LGTM, thanks.
4 years, 10 months ago (2016-02-25 12:24:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738823002/1
4 years, 10 months ago (2016-02-25 12:38:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 12:49:07 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 12:49:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40bf2d7eee90c47ca6c8e6cb6098cb11d9bf303b
Cr-Commit-Position: refs/heads/master@{#34289}

Powered by Google App Engine
This is Rietveld 408576698