Add methods to SceneOverlay interface

Add methods to SceneOverlay interface

This change adds onBackPressed, onHideLayout, and handlesTabCreating
to the SceneOverlay interface. If any of the SceneOverlays for a
layout claim to handle tab creation, the normal animation will be
skipped.

BUG=584340
Committed: https://crrev.com/a4c4b94e33a3b9d16eb5a09a2e2fa227def420ea
Cr-Commit-Position: refs/heads/master@{#387766}

[mdjones, 2016-02-26 03:41:00]

PTAL

[mdjones, 2016-02-26 03:41:14]

mdjones@chromium.org changed reviewers:
+ dtrainor@chromium.org

[mdjones, 2016-02-26 03:41:14]

PTAL

[mdjones, 2016-02-29 21:52:26]

Description was changed from

==========
Add methods to SceneOverlay interface

This change adds onUpdateAnimation and handlesTabCreating to the
SceneOverlay interface. If any of the SceneOverlays for a layout
claim to handle tab creation, the normal animation will be skipped.

BUG=584340
==========

to

==========
Add methods to SceneOverlay interface

This change adds onBackPressed and handlesTabCreating to the
SceneOverlay interface. If any of the SceneOverlays for a layout
claim to handle tab creation, the normal animation will be skipped.

BUG=584340
==========

[mdjones, 2016-02-29 21:53:13]

I replaced the animation function I added with one that handles back button
presses. PTAL

[David Trainor- moved to gerrit, 2016-03-08 22:28:12]

https://codereview.chromium.org/1738803004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
(right):

https://codereview.chromium.org/1738803004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java:1083:
public boolean isTabCreatingIntercepted() {
I might rename this.  isXYZ makes me think it's just asking if it supports XYZ,
not that it's doing stuff.

[mdjones, 2016-03-09 18:25:55]

https://codereview.chromium.org/1738803004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
(right):

https://codereview.chromium.org/1738803004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java:1083:
public boolean isTabCreatingIntercepted() {
On 2016/03/08 22:28:12, David Trainor wrote:
> I might rename this.  isXYZ makes me think it's just asking if it supports
XYZ,
> not that it's doing stuff.

I merged this function with the one above; I think this makes more sense than
what I had and solves the name problem.

[mdjones, 2016-03-18 20:27:05]

Description was changed from

==========
Add methods to SceneOverlay interface

This change adds onBackPressed and handlesTabCreating to the
SceneOverlay interface. If any of the SceneOverlays for a layout
claim to handle tab creation, the normal animation will be skipped.

BUG=584340
==========

to

==========
Add methods to SceneOverlay interface

This change adds onBackPressed, onHideLayout, and handlesTabCreating
to the SceneOverlay interface. If any of the SceneOverlays for a
layout claim to handle tab creation, the normal animation will be
skipped.

BUG=584340
==========

[David Trainor- moved to gerrit, 2016-04-15 16:02:27]

lgtm with question

https://codereview.chromium.org/1738803004/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java
(right):

https://codereview.chromium.org/1738803004/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java:194:
return mHandlesTabLifecycles || super.handlesTabCreating();
Just to confirm if mHandlesTabLifecycles == true you don't want
super.handlesTabCreating() to be run?

[mdjones, 2016-04-15 21:20:49]

https://codereview.chromium.org/1738803004/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java
(right):

https://codereview.chromium.org/1738803004/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java:194:
return mHandlesTabLifecycles || super.handlesTabCreating();
On 2016/04/15 16:02:27, David Trainor (OOO until 4-11) wrote:
> Just to confirm if mHandlesTabLifecycles == true you don't want
> super.handlesTabCreating() to be run?

Good catch! Swapped order.

[mdjones, 2016-04-15 22:37:04]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-04-15 22:37:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/1738803004/#ps100001
(title: "make sure super.handlesTabCreating is run")

[commit-bot: I haz the power, 2016-04-15 22:37:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1738803004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1738803004/100001

[commit-bot: I haz the power, 2016-04-16 00:26:36]

Description was changed from

==========
Add methods to SceneOverlay interface

This change adds onBackPressed, onHideLayout, and handlesTabCreating
to the SceneOverlay interface. If any of the SceneOverlays for a
layout claim to handle tab creation, the normal animation will be
skipped.

BUG=584340
==========

to

==========
Add methods to SceneOverlay interface

This change adds onBackPressed, onHideLayout, and handlesTabCreating
to the SceneOverlay interface. If any of the SceneOverlays for a
layout claim to handle tab creation, the normal animation will be
skipped.

BUG=584340
==========

[commit-bot: I haz the power, 2016-04-16 00:26:37]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-16 00:28:03]

Description was changed from

==========
Add methods to SceneOverlay interface

This change adds onBackPressed, onHideLayout, and handlesTabCreating
to the SceneOverlay interface. If any of the SceneOverlays for a
layout claim to handle tab creation, the normal animation will be
skipped.

BUG=584340
==========

to

==========
Add methods to SceneOverlay interface

This change adds onBackPressed, onHideLayout, and handlesTabCreating
to the SceneOverlay interface. If any of the SceneOverlays for a
layout claim to handle tab creation, the normal animation will be
skipped.

BUG=584340

Committed: https://crrev.com/a4c4b94e33a3b9d16eb5a09a2e2fa227def420ea
Cr-Commit-Position: refs/heads/master@{#387766}
==========

[commit-bot: I haz the power, 2016-04-16 00:28:04]

Patchset 6 (id:??) landed as
https://crrev.com/a4c4b94e33a3b9d16eb5a09a2e2fa227def420ea
Cr-Commit-Position: refs/heads/master@{#387766}