tools/android/loading/loading_trace_analyzer.py - Issue 1738803003: tools/android/loading: Implements loading_trace_analyzer.py's unittest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/loading/loading_trace_analyzer.py

Issue 1738803003: tools/android/loading: Implements loading_trace_analyzer.py's unittest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@i11

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/android/loading/loading_trace_analyzer.py

diff --git a/tools/android/loading/loading_trace_analyzer.py b/tools/android/loading/loading_trace_analyzer.py

index e70336030005c83b7f2b7b9633bcdae12ac797e5..b1aaf2075cc601577893196a59110958d9f58305 100755

--- a/tools/android/loading/loading_trace_analyzer.py

+++ b/tools/android/loading/loading_trace_analyzer.py

@@ -24,7 +24,7 @@ def _ArgumentParser():

requests_parser.add_argument('loading_trace', type=file,

help='Input loading trace to see the cache usage from.')

requests_parser.add_argument('--output',

- type=argparse.FileType(),

+ type=argparse.FileType('w'),

default=sys.stdout,

help='Output destination path if different from stdout.')

requests_parser.add_argument('--output-format', type=str, default='{url}',

« no previous file with comments | « no previous file | tools/android/loading/loading_trace_analyzer_unittest.py » ('j') | tools/android/loading/loading_trace_analyzer_unittest.py » ('J')