Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1738733003: Changelog update to include `@required`. (Closed)

Created:
4 years, 10 months ago by pquitslund
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M pkg/meta/CHANGELOG.md View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
May get a quick rev with `@mustCallSuper` but I may want to publish in the ...
4 years, 10 months ago (2016-02-25 22:03:00 UTC) #2
Brian Wilkerson
LGTM. I'll update the change log before committing @mustCallSuper.
4 years, 10 months ago (2016-02-25 22:15:29 UTC) #3
pquitslund
4 years, 10 months ago (2016-02-25 22:16:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
14b417c36dec739acdc87ed5af9f6c4c5c80660e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698