Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1738723003: [debugger] fix --print-break-location for multiline scripts. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 10 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] fix --print-break-location for multiline scripts. We otherwise would print the \n from the last line. R=vogelheim@chromium.org Committed: https://crrev.com/9d0d5fd20d47009c62e11c73b31539af554c717f Cr-Commit-Position: refs/heads/master@{#34291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/debug/debug.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 10 months ago (2016-02-25 12:28:28 UTC) #1
vogelheim
lgtm
4 years, 10 months ago (2016-02-25 12:35:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738723003/1
4 years, 10 months ago (2016-02-25 12:36:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 13:00:19 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 13:01:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d0d5fd20d47009c62e11c73b31539af554c717f
Cr-Commit-Position: refs/heads/master@{#34291}

Powered by Google App Engine
This is Rietveld 408576698