Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: mojo/shell/runner/child/runner_connection.h

Issue 1738663002: Hook embedded shell up to MojoShellConnection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/application_manager.cc ('k') | mojo/shell/runner/child/runner_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/runner/child/runner_connection.h
diff --git a/mojo/shell/runner/child/runner_connection.h b/mojo/shell/runner/child/runner_connection.h
index 488b9968623dd2eafc9dff80d0135d48e5ab7188..e49f73e60e8d4d07041f2970c40f87fffe9703b7 100644
--- a/mojo/shell/runner/child/runner_connection.h
+++ b/mojo/shell/runner/child/runner_connection.h
@@ -21,11 +21,20 @@ class RunnerConnection {
// Establish a connection to the runner, blocking the calling thread until
// it is established. The Application request from the runner is returned via
// |request|.
+ //
// If a connection to the runner cannot be established, |request| will not be
// modified and this function will return null.
+ //
+ // If |exit_on_error| is true, the calling process will be terminated in the
+ // event of an error on |handle|.
+ //
+ // TODO(rockot): Remove |exit_on_error| when it's safe for all clients to be
+ // terminated on such errors. For now we don't want this killing content's
+ // child processes.
static RunnerConnection* ConnectToRunner(
InterfaceRequest<mojom::ShellClient>* request,
- ScopedMessagePipeHandle handle);
+ ScopedMessagePipeHandle handle,
+ bool exit_on_error = true);
protected:
RunnerConnection();
« no previous file with comments | « mojo/shell/application_manager.cc ('k') | mojo/shell/runner/child/runner_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698