Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1738633002: Subzero: Provide "make sb" target for sandboxed pnacl-sz. (Closed)

Created:
4 years, 10 months ago by Jim Stichnoth
Modified:
4 years, 10 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Provide "make sb" target for sandboxed pnacl-sz. Instead of "./pnacl-sz <args>", one can run: ../../../run.py ./pnacl-sz.x8632.nexe <args> or ../../../run.py ./pnacl-sz.x8664.nexe <args> Hopefully the translator performance characteristics are close to that of the browser hookup. Adds sb builds to two of the presubmit configurations. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7a20a40facac14ee721bd890182b090b77c3fef4

Patch Set 1 #

Patch Set 2 : Fix some formatting #

Patch Set 3 : Add a couple of builds to "make presubmit" #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M Makefile.standalone View 1 2 9 chunks +31 lines, -13 lines 2 comments Download

Messages

Total messages: 8 (4 generated)
Jim Stichnoth
4 years, 10 months ago (2016-02-25 02:33:27 UTC) #4
John
lgtm https://codereview.chromium.org/1738633002/diff/40001/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1738633002/diff/40001/Makefile.standalone#newcode376 Makefile.standalone:376: Arm32?? Totally optional, and up to you.
4 years, 10 months ago (2016-02-25 02:36:56 UTC) #5
Jim Stichnoth
https://codereview.chromium.org/1738633002/diff/40001/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1738633002/diff/40001/Makefile.standalone#newcode376 Makefile.standalone:376: On 2016/02/25 02:36:56, John wrote: > Arm32?? Totally optional, ...
4 years, 10 months ago (2016-02-25 05:32:20 UTC) #6
Jim Stichnoth
4 years, 10 months ago (2016-02-25 05:32:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
7a20a40facac14ee721bd890182b090b77c3fef4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698