Issue 173863002: Revert of Fix crash which occurs when a widget destroys itself as a result of ET_GESTURE_TAP_DOWN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173863002: Revert of Fix crash which occurs when a widget destroys itself as a result of ET_GESTURE_TAP_DOWN (Closed)

Created:
6 years, 10 months ago by Dmitry Lomov (no reviews)

Modified:
6 years, 10 months ago

Reviewers:
pkotwicz, sadrul

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Fix crash which occurs when a widget destroys itself as a result of ET_GESTURE_TAP_DOWN (https://codereview.chromium.org/169443005/) Reason for revert: Breaks ChromiumOS ASAN: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%281%29/builds/15949 Original issue's description: > Fix crash which occurs when a widget destroys itself as a result of ET_GESTURE_TAP_DOWN > > BUG=342867 > TEST=WidgetTest.WidgetDeleted_InDispatchGestureEvent > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252214 TBR=sadrul@chromium.org,pkotwicz@chromium.org NOTREECHECKS=true NOTRY=true BUG=342867 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252235

Created: 6 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+124 lines, -150 lines)			Patch
M	ui/views/widget/root_view.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	ui/views/widget/root_view.cc	View	18 chunks	+37 lines, -85 lines	0 comments	Download
M	ui/views/widget/widget_unittest.cc	View	6 chunks	+86 lines, -62 lines	0 comments	Download