third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp - Issue 1738623004: Rename enums/functions that collide in chromium style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp

Issue 1738623004: Rename enums/functions that collide in chromium style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-names-4

Patch Set: get-names-5: rebase-and-stuff Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.h ('k') | third_party/WebKit/Source/core/html/parser/HTMLSrcsetParserTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp b/third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp

index 7b540e467c896849981c935455213d3509619dcf..f90e555c35d79fa6fe429a37ebcdfb4a466284a8 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp

@@ -370,8 +370,8 @@ static ImageCandidate pickBestImageCandidate(float deviceScaleFactor, float sour

// http://picture.responsiveimages.org/#normalize-source-densities

for (ImageCandidate& image : imageCandidates) {

- if (image.resourceWidth() > 0) {

- image.setDensity((float)image.resourceWidth() / sourceSize);

+ if (image.getResourceWidth() > 0) {

+ image.setDensity((float)image.getResourceWidth() / sourceSize);

ignoreSrc = true;

} else if (image.density() < 0) {

image.setDensity(defaultDensityValue);