third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp - Issue 1738623004: Rename enums/functions that collide in chromium style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp

Issue 1738623004: Rename enums/functions that collide in chromium style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-names-4

Patch Set: get-names-5: rebase-and-stuff Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp

index db3e4c0a8fe1c21779bfac1fadd6dfb3dbfac9a2..ab842510f46770a7fcf3e9af0a589f6a5a8f5864 100644

--- a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp

@@ -35,7 +35,7 @@ TEST_F(SerializedScriptValueTest, UserSelectedFile)

filePath.append("/Source/bindings/core/v8/SerializedScriptValueTest.cpp");

File* originalFile = File::create(filePath);

ASSERT_TRUE(originalFile->hasBackingFile());

- ASSERT_EQ(File::IsUserVisible, originalFile->userVisibility());

+ ASSERT_EQ(File::IsUserVisible, originalFile->getUserVisibility());

ASSERT_EQ(filePath, originalFile->path());

v8::Local<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate());

@@ -46,7 +46,7 @@ TEST_F(SerializedScriptValueTest, UserSelectedFile)

ASSERT_TRUE(V8File::hasInstance(v8File, isolate()));

File* file = V8File::toImpl(v8::Local<v8::Object>::Cast(v8File));

EXPECT_TRUE(file->hasBackingFile());

- EXPECT_EQ(File::IsUserVisible, file->userVisibility());

+ EXPECT_EQ(File::IsUserVisible, file->getUserVisibility());

EXPECT_EQ(filePath, file->path());

}

@@ -55,7 +55,7 @@ TEST_F(SerializedScriptValueTest, FileConstructorFile)

RefPtr<BlobDataHandle> blobDataHandle = BlobDataHandle::create();

File* originalFile = File::create("hello.txt", 12345678.0, blobDataHandle);

ASSERT_FALSE(originalFile->hasBackingFile());

- ASSERT_EQ(File::IsNotUserVisible, originalFile->userVisibility());

+ ASSERT_EQ(File::IsNotUserVisible, originalFile->getUserVisibility());

ASSERT_EQ("hello.txt", originalFile->name());

v8::Local<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate());

@@ -66,7 +66,7 @@ TEST_F(SerializedScriptValueTest, FileConstructorFile)

ASSERT_TRUE(V8File::hasInstance(v8File, isolate()));

File* file = V8File::toImpl(v8::Local<v8::Object>::Cast(v8File));

EXPECT_FALSE(file->hasBackingFile());

- EXPECT_EQ(File::IsNotUserVisible, file->userVisibility());

+ EXPECT_EQ(File::IsNotUserVisible, file->getUserVisibility());

EXPECT_EQ("hello.txt", file->name());

}