Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1738603002: Sequential focus navigation staring point: Fix a case where clicked Text node has focusable sibling… (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sequential focus navigation staring point: Fix a case where clicked Text node has focusable siblings. In the following case: <div> <input> text <input> <div> If the "text" is clicked, we wrongly record its parent elemnt as sequential focus navigation starting point. We should record the Text node as is. BUG=454172 TEST=automated Committed: https://crrev.com/eaebbf00d55e4a2d2a4b3f82542686d2fc08149c Cr-Commit-Position: refs/heads/master@{#377499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/sequential-focus-navigation-starting-point.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
Kochi-san, would you review this please?
4 years, 10 months ago (2016-02-25 01:38:17 UTC) #2
kochi
Good catch! lgtm
4 years, 10 months ago (2016-02-25 01:49:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738603002/1
4 years, 10 months ago (2016-02-25 03:16:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 04:06:35 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 04:08:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eaebbf00d55e4a2d2a4b3f82542686d2fc08149c
Cr-Commit-Position: refs/heads/master@{#377499}

Powered by Google App Engine
This is Rietveld 408576698