Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 1738573002: Adding support for the -- convention for cmd line args. (Closed)

Created:
4 years, 10 months ago by Mike Meade
Modified:
4 years, 10 months ago
Reviewers:
shadi1, M-A Ruel, shadi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding support for the -- convention for cmd line args. The kitchensync team needs the ability to pass args directly to the controller task. BUG= Committed: https://crrev.com/0b6bdc30d4cd0ca93f392f0dee2d54d76c5ce4fb Cr-Commit-Position: refs/heads/master@{#377440}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M testing/legion/tools/legion.py View 1 6 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Mike Meade
PTAL
4 years, 10 months ago (2016-02-24 23:43:54 UTC) #3
M-A Ruel
rubberstamp lgtm
4 years, 10 months ago (2016-02-24 23:46:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738573002/20001
4 years, 10 months ago (2016-02-24 23:49:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-25 00:40:49 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0b6bdc30d4cd0ca93f392f0dee2d54d76c5ce4fb Cr-Commit-Position: refs/heads/master@{#377440}
4 years, 10 months ago (2016-02-25 00:41:48 UTC) #10
shadi1
4 years, 10 months ago (2016-02-25 18:58:17 UTC) #12
Message was sent while issue was closed.
Thanks for the CL.

PS: if you just want to CC me to a CL add me to the CC list instead of the
reviewers list. Usually all reviewers are required to LGTM if added (even though
it is not needed for commit).

Powered by Google App Engine
This is Rietveld 408576698