Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1738563002: Remove //tools/profile_chrome from Chromium repo (Closed)

Created:
4 years, 10 months ago by Zhen Wang
Modified:
4 years, 10 months ago
Reviewers:
jbudorick, Sami
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove //tools/profile_chrome from Chromium repo The previous CL (https://crrev.com/1726783002/) copied //tools/profile_chrome to Catapult. This CL removes //tools/profile_chrome in Chromium repo and updates the dependency. BUG=catapult:#1937 TBR=thakis@chromium.org Committed: https://crrev.com/bbc6b8838d109d972314f404953ebd1e862169de Cr-Commit-Position: refs/heads/master@{#377733}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2114 lines) Patch
M build/android/adb_profile_chrome View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
A build/android/adb_profile_chrome_startup View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M tools/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/licenses.py View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/profile_chrome.py View 1 chunk +0 lines, -13 lines 0 comments Download
D tools/profile_chrome/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/profile_chrome/__init__.py View 1 chunk +0 lines, -12 lines 0 comments Download
D tools/profile_chrome/chrome_controller.py View 1 chunk +0 lines, -115 lines 0 comments Download
D tools/profile_chrome/chrome_controller_unittest.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/profile_chrome/chrome_startup_controller.py View 1 chunk +0 lines, -72 lines 0 comments Download
D tools/profile_chrome/chrome_startup_controller_unittest.py View 1 chunk +0 lines, -28 lines 0 comments Download
D tools/profile_chrome/controllers.py View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/profile_chrome/controllers_unittest.py View 1 chunk +0 lines, -24 lines 0 comments Download
D tools/profile_chrome/ddms_controller.py View 1 chunk +0 lines, -54 lines 0 comments Download
D tools/profile_chrome/ddms_controller_unittest.py View 1 chunk +0 lines, -26 lines 0 comments Download
D tools/profile_chrome/flags.py View 1 chunk +0 lines, -26 lines 0 comments Download
D tools/profile_chrome/main.py View 1 chunk +0 lines, -267 lines 0 comments Download
D tools/profile_chrome/perf_controller.py View 1 chunk +0 lines, -188 lines 0 comments Download
D tools/profile_chrome/perf_controller_unittest.py View 1 chunk +0 lines, -40 lines 0 comments Download
D tools/profile_chrome/profiler.py View 1 chunk +0 lines, -88 lines 0 comments Download
D tools/profile_chrome/profiler_unittest.py View 1 chunk +0 lines, -78 lines 0 comments Download
D tools/profile_chrome/run_tests View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/profile_chrome/systrace_controller.py View 1 chunk +0 lines, -112 lines 0 comments Download
D tools/profile_chrome/systrace_controller_unittest.py View 1 chunk +0 lines, -37 lines 0 comments Download
D tools/profile_chrome/third_party/COPYING View 1 chunk +0 lines, -339 lines 0 comments Download
D tools/profile_chrome/third_party/README.chromium View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/profile_chrome/third_party/perf_to_tracing.py View 1 chunk +0 lines, -248 lines 0 comments Download
D tools/profile_chrome/trace_packager.py View 1 chunk +0 lines, -92 lines 0 comments Download
D tools/profile_chrome/trace_packager_unittest.py View 1 chunk +0 lines, -35 lines 0 comments Download
D tools/profile_chrome/ui.py View 1 chunk +0 lines, -27 lines 0 comments Download
D tools/profile_chrome/util.py View 1 chunk +0 lines, -8 lines 0 comments Download
D tools/profile_chrome_startup.py View 1 chunk +0 lines, -102 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Zhen Wang
ptal This CL will be landed after https://codereview.chromium.org/1736633004/ https://codereview.chromium.org/1738563002/diff/20001/tools/profile_chrome.py File tools/profile_chrome.py (left): https://codereview.chromium.org/1738563002/diff/20001/tools/profile_chrome.py#oldcode1 tools/profile_chrome.py:1: #!/usr/bin/env ...
4 years, 10 months ago (2016-02-25 00:14:40 UTC) #5
Sami
Yep, that seems appropriate. All all (most?) documentation points to build/android/adb_profile_chrome anyway. lgtm.
4 years, 10 months ago (2016-02-25 10:50:02 UTC) #6
Zhen Wang
+ jbudorick for //build/android
4 years, 10 months ago (2016-02-25 16:53:44 UTC) #8
Zhen Wang
+jbudorick for //build/android
4 years, 10 months ago (2016-02-25 16:54:06 UTC) #10
jbudorick
build/android/ lgtm
4 years, 10 months ago (2016-02-25 16:56:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738563002/60001
4 years, 10 months ago (2016-02-25 22:57:05 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-26 00:46:40 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 00:48:48 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bbc6b8838d109d972314f404953ebd1e862169de
Cr-Commit-Position: refs/heads/master@{#377733}

Powered by Google App Engine
This is Rietveld 408576698