third_party/WebKit/Source/core/fetch/ResourceLoader.cpp - Issue 1738553002: [ABANDONED] Move multipart/x-mixed-replace related code to ImageResource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceLoader.cpp

Issue 1738553002: [ABANDONED] Move multipart/x-mixed-replace related code to ImageResource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@multipart-cleanup-2

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/Resource.cpp ('K') | « third_party/WebKit/Source/core/fetch/Resource.cpp ('k') | third_party/WebKit/Source/core/fetch/ScriptResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceLoader.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp b/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp

index 99b65f97b91dff470c2fca99fb45da1444d71333..ed2180779e3242db2187960256d44b769faf8c62 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp

+++ b/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp

@@ -321,10 +321,8 @@ void ResourceLoader::didReceiveResponse(WebURLLoader*, const WebURLResponse& res

// |rawHandle|'s ownership is transferred to the callee.

OwnPtr<WebDataConsumerHandle> handle = adoptPtr(rawHandle);

- bool isMultipartPayload = response.isMultipartPayload();

bool isValidStateTransition = (m_connectionState == ConnectionStateStarted || m_connectionState == ConnectionStateReceivedResponse);

- // In the case of multipart loads, calls to didReceiveData & didReceiveResponse can be interleaved.

- RELEASE_ASSERT(isMultipartPayload || isValidStateTransition);

+ RELEASE_ASSERT(isValidStateTransition);

m_connectionState = ConnectionStateReceivedResponse;

const ResourceResponse& resourceResponse = response.toResourceResponse();