Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp

Issue 1738553002: [ABANDONED] Move multipart/x-mixed-replace related code to ImageResource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@multipart-cleanup-2
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp b/third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp
index fdcc630fedab4fb73b1283ce9403c96b9c78c863..24a4b13a3c9fb28e24663d5eadd2500975649daf 100644
--- a/third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp
@@ -30,8 +30,11 @@ class MockClient final : public NoBaseWillBeGarbageCollectedFinalized<MockClient
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MockClient);
public:
- void didReceiveResponse(const ResourceResponse& response) override
+ void didReceiveResponse(const ResourceResponse& response, bool isFirstPart) override
{
+ if (isFirstPart != m_responses.isEmpty())
+ FAIL() << "m_responses.size() = " << m_responses.size() << ", isFirstPart = " << isFirstPart;
+
m_responses.append(response);
m_data.append(Vector<char>());
}
@@ -382,7 +385,7 @@ TEST(MultipartResponseTest, MultipleBoundaries)
EXPECT_EQ("foofoo", toString(client->m_data[1]));
}
-TEST(MultipartResponseTest, MultipartPayloadSet)
+TEST(MultipartResponseTest, IsFirstPartSet)
{
ResourceResponse response;
response.setMimeType("multipart/x-mixed-replace");
@@ -392,6 +395,7 @@ TEST(MultipartResponseTest, MultipartPayloadSet)
MultipartImageResourceParser* parser = new MultipartImageResourceParser(response, boundary, client);
+ // isFirstPart is checked at MockClient::didReceiveResponse.
const char data[] =
"--bound\n"
"Content-type: text/plain\n\n"
@@ -401,7 +405,6 @@ TEST(MultipartResponseTest, MultipartPayloadSet)
ASSERT_EQ(1u, client->m_responses.size());
ASSERT_EQ(1u, client->m_data.size());
EXPECT_EQ("response data", toString(client->m_data[0]));
- EXPECT_FALSE(client->m_responses[0].isMultipartPayload());
const char data2[] =
"Content-type: text/plain\n\n"
@@ -411,7 +414,6 @@ TEST(MultipartResponseTest, MultipartPayloadSet)
ASSERT_EQ(2u, client->m_responses.size());
ASSERT_EQ(2u, client->m_data.size());
EXPECT_EQ("response data2", toString(client->m_data[1]));
- EXPECT_TRUE(client->m_responses[1].isMultipartPayload());
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698