third_party/WebKit/Source/core/dom/DOMImplementation.cpp - Issue 1738553002: [ABANDONED] Move multipart/x-mixed-replace related code to ImageResource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMImplementation.cpp

Issue 1738553002: [ABANDONED] Move multipart/x-mixed-replace related code to ImageResource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@multipart-cleanup-2

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/page_load_histograms.cc ('K') | « third_party/WebKit/LayoutTests/http/tests/multipart/multipart-main-resource-expected.html ('k') | third_party/WebKit/Source/core/fetch/ImageResource.h » ('j') | third_party/WebKit/Source/core/fetch/ImageResource.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/DOMImplementation.cpp

diff --git a/third_party/WebKit/Source/core/dom/DOMImplementation.cpp b/third_party/WebKit/Source/core/dom/DOMImplementation.cpp

index d7e98ed3c5e027e02fb31936f4c5184dc8497d62..842185f1a4a92c8355428c7bf7e9f28eec7c54ba 100644

--- a/third_party/WebKit/Source/core/dom/DOMImplementation.cpp

+++ b/third_party/WebKit/Source/core/dom/DOMImplementation.cpp

@@ -234,7 +234,8 @@ PassRefPtrWillBeRawPtr<Document> DOMImplementation::createDocument(const String&

// We do not want QuickTime to take over all image types, obviously.

if ((type == "application/pdf" || type == "text/pdf") && pluginData && pluginData->supportsMimeType(type))

return PluginDocument::create(init);

- if (Image::supportsType(type))

+ // multipart/x-mixed-replace is only supported for images.

+ if (Image::supportsType(type) || type == "multipart/x-mixed-replace")

return ImageDocument::create(init);

// Check to see if the type can be played by our media player, if so create a MediaDocument