components/page_load_metrics/renderer/metrics_render_frame_observer.cc - Issue 1738553002: [ABANDONED] Move multipart/x-mixed-replace related code to ImageResource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 1738553002: [ABANDONED] Move multipart/x-mixed-replace related code to ImageResource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@multipart-cleanup-2

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/page_load_histograms.cc ('K') | « chrome/renderer/page_load_histograms.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | third_party/WebKit/Source/core/fetch/ImageResource.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

index ed6e8be2457f86d47cff73be0cf64152ab151972..f41d67dc7347a4b4e0d65bfea3ef54ddb342b01c 100644

--- a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

@@ -85,10 +85,6 @@ bool MetricsRenderFrameObserver::ShouldSendMetrics() const {

return false;

const blink::WebURLResponse& url_response = frame->dataSource()->response();

- // Ignore multipart responses (e.g. MHTML).

- if (url_response.isMultipartPayload())

- return false;

// Ignore non-HTML documents (e.g. SVG). Note that images are treated by

// Blink as HTML documents, so to exclude images, we must perform

// additional mime type checking below.