Make OpenSSL UpdateServerCert() OS independent.

net/socket/ssl_client_socket_nss.h

Index: net/socket/ssl_client_socket_nss.h
diff --git a/net/socket/ssl_client_socket_nss.h b/net/socket/ssl_client_socket_nss.h
index 47fed74d9d3361f131840b487e0971929b224b9f..9b93257e32f00e3c7e6a6c328341e71bb1b799ee 100644
--- a/net/socket/ssl_client_socket_nss.h
+++ b/net/socket/ssl_client_socket_nss.h
@@ -80,6 +80,9 @@ class SSLClientSocketNSS : public SSLClientSocket {
                                    unsigned char* out,
                                    unsigned int outlen) OVERRIDE;
   virtual int GetTLSUniqueChannelBinding(std::string* out) OVERRIDE;
+  // For unit testing only.
+  virtual const scoped_refptr<X509Certificate> GetUnverifiedServerCertificate()

[wtc, 2014/03/10 21:45:34]

1. This method is listed under the "SSLSocket implementation" section (see line
76), but it is a method of SSLClientSocket. So it is listed under the wrong
section.

2. More important: should this method be public? The base class SSLClientSocket
declares this method as private.

[Ryan Sleevi, 2014/03/11 00:15:15]

did you mean for this to be "const scoped_refptr<X509Certificate>&" ?

the const does nothing otherwise.

[haavardm, 2014/03/11 18:43:21]

No need for scoped pointer here at all, so I'll use const X509Certificate*
instead to allow returning NULL in the mock implementation.

[haavardm, 2014/03/11 18:43:21]

Done.

+      const OVERRIDE;
 
   // StreamSocket implementation.
   virtual int Connect(const CompletionCallback& callback) OVERRIDE;