Make OpenSSL UpdateServerCert() OS independent.

net/socket/ssl_client_socket_nss.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_NSS_H_
 #define NET_SOCKET_SSL_CLIENT_SOCKET_NSS_H_
 
 #include <certt.h>
 #include <keyt.h>
 #include <nspr.h>
@@ skipping 88 matching lines @@
   virtual int Read(IOBuffer* buf,
                    int buf_len,
                    const CompletionCallback& callback) OVERRIDE;
   virtual int Write(IOBuffer* buf,
                     int buf_len,
                     const CompletionCallback& callback) OVERRIDE;
   virtual bool SetReceiveBufferSize(int32 size) OVERRIDE;
   virtual bool SetSendBufferSize(int32 size) OVERRIDE;
   virtual ServerBoundCertService* GetServerBoundCertService() const OVERRIDE;
 
+ protected:
+  // SSLClientSocket implementation.
+  virtual const X509Certificate* GetUnverifiedServerCertificateChain() const

[Ryan Sleevi, 2014/03/12 23:12:03]

Don't return raw pointers to ref-counted types. It can actually lead to subtle
UAF (there in fact was a rather ugly one with an internal function that returned
an X509Certificate* - even though it was immediatedly placed into a
scoped_refptr)

either "const scoped_refptr<X509Certificate>&" (if it's always stored) or
"scoped_refptr<X509Certificate>" (if not). X509Certificates themselves are
immutable.

[haavardm, 2014/03/13 10:32:02]

OK.  Didn't realize X509Certificate was immutable. My thinking was that one
never takes ownership or passes on const pointers unless it is  documented. The
Mock implementations  returns NULL, so I'll change to
scoped_refptr<X509Certificate>.

+      OVERRIDE;
+
  private:
   // Helper class to handle marshalling any NSS interaction to and from the
   // NSS and network task runners. Not every call needs to happen on the Core
   class Core;
 
   enum State {
     STATE_NONE,
     STATE_HANDSHAKE,
     STATE_HANDSHAKE_COMPLETE,
     STATE_VERIFY_CERT,
@@ skipping 82 matching lines @@
   // Added the following code Debugging in release mode.
   mutable base::Lock lock_;
   // This is mutable so that CalledOnValidThread can set it.
   // It's guarded by |lock_|.
   mutable base::PlatformThreadId valid_thread_id_;
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_SSL_CLIENT_SOCKET_NSS_H_