Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/media_galleries/media_folder_finder.h

Issue 173853007: Media Galleries: Prune uninteresting folders when scanning. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: add tests, fix bugs Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/media_folder_finder.h
===================================================================
--- chrome/browser/media_galleries/media_folder_finder.h (revision 252098)
+++ chrome/browser/media_galleries/media_folder_finder.h (working copy)
@@ -19,8 +19,13 @@
// media files.
class MediaFolderFinder {
public:
+ // Key: path to a folder
+ // Value: scan results for that folder, non-recursive.
typedef std::map<base::FilePath, MediaGalleryScanResult>
MediaFolderFinderResults;
+
+ // |results| never contains entries for |graylisted_folders_| or parent
+ // directories of |graylisted_folders_|.
typedef base::Callback<void(bool /*success*/,
const MediaFolderFinderResults& /*results*/)>
MediaFolderFinderResultsCallback;
@@ -36,6 +41,8 @@
// Start the scan.
virtual void StartScan();
+ const std::vector<base::FilePath>& graylisted_folders() const;
+
private:
friend class MediaFolderFinderTest;
@@ -67,6 +74,7 @@
const MediaFolderFinderResultsCallback results_callback_;
MediaFolderFinderResults results_;
+ std::vector<base::FilePath> graylisted_folders_;
std::vector<base::FilePath> folders_to_scan_;
ScanState scan_state_;

Powered by Google App Engine
This is Rietveld 408576698