Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1738503002: Add libdart_precompiled_runtime target to runtime/BUILD.gn (Closed)

Created:
4 years, 10 months ago by Florian Schneider
Modified:
4 years, 10 months ago
Reviewers:
rmacnak, Chinmay
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add libdart_precompiled_runtime target to runtime/BUILD.gn This allows the embedder using the gn build files build a VM runtime without compiler-related code, used to run a precompiled snapshot. It is a copy of libdart, but has the macro DART_PRECOMPILED_RUNTIME defined which excludes all compiler-related code, not needed to run precompiled code from the binary. BUG= R=chinmaygarde@google.com Committed: https://github.com/dart-lang/sdk/commit/289157044a21ea999df9277095dba720848a8bfe

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix after merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -0 lines) Patch
M runtime/BUILD.gn View 1 2 chunks +91 lines, -0 lines 0 comments Download
M runtime/vm/BUILD.gn View 1 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Florian Schneider
4 years, 10 months ago (2016-02-24 21:48:49 UTC) #3
rmacnak
https://codereview.chromium.org/1738503002/diff/1/runtime/BUILD.gn File runtime/BUILD.gn (left): https://codereview.chromium.org/1738503002/diff/1/runtime/BUILD.gn#oldcode53 runtime/BUILD.gn:53: if (is_ios || is_mac) { We can't remove this ...
4 years, 10 months ago (2016-02-25 00:42:46 UTC) #5
Florian Schneider
ptal
4 years, 10 months ago (2016-02-25 17:32:06 UTC) #11
Chinmay
On 2016/02/25 at 17:32:06, fschneider wrote: > ptal This looks good to me and I ...
4 years, 10 months ago (2016-02-25 21:27:23 UTC) #12
Florian Schneider
Committed patchset #2 (id:80001) manually as 289157044a21ea999df9277095dba720848a8bfe (presubmit successful).
4 years, 10 months ago (2016-02-25 21:44:33 UTC) #14
Florian Schneider
4 years, 10 months ago (2016-02-25 21:45:05 UTC) #15
Message was sent while issue was closed.
On 2016/02/25 21:27:23, Chinmay wrote:
> On 2016/02/25 at 17:32:06, fschneider wrote:
> > ptal
> 
> This looks good to me and I see the savings in size of the final binary. I am
> sure there is an easier way to make the configs inherit one another for a
> clearer GN file. But we can figure it out in a later patch if you want. lgtm
> (but I am not an owner or anything)

Thanks for testing it! I'll land this as is for now and try to simplify the gn
files in a separate CL.

Powered by Google App Engine
This is Rietveld 408576698