Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py

Issue 17385018: Remove the --no-http option to run-webkit-tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Sze ged 2 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Sze ged
3 # Copyright (C) 2011 Apple Inc. All rights reserved. 3 # Copyright (C) 2011 Apple Inc. All rights reserved.
4 # 4 #
5 # Redistribution and use in source and binary forms, with or without 5 # Redistribution and use in source and binary forms, with or without
6 # modification, are permitted provided that the following conditions are 6 # modification, are permitted provided that the following conditions are
7 # met: 7 # met:
8 # 8 #
9 # * Redistributions of source code must retain the above copyright 9 # * Redistributions of source code must retain the above copyright
10 # notice, this list of conditions and the following disclaimer. 10 # notice, this list of conditions and the following disclaimer.
(...skipping 763 matching lines...) Expand 10 before | Expand all | Expand 10 after
774 self.assertTrue(passing_run(['--additional-platform-directory', '/tmp/.. /foo'])) 774 self.assertTrue(passing_run(['--additional-platform-directory', '/tmp/.. /foo']))
775 self.assertTrue(passing_run(['--additional-platform-directory', '/tmp/fo o', '--additional-platform-directory', '/tmp/bar'])) 775 self.assertTrue(passing_run(['--additional-platform-directory', '/tmp/fo o', '--additional-platform-directory', '/tmp/bar']))
776 self.assertTrue(passing_run(['--additional-platform-directory', 'foo'])) 776 self.assertTrue(passing_run(['--additional-platform-directory', 'foo']))
777 777
778 def test_additional_expectations(self): 778 def test_additional_expectations(self):
779 host = MockHost() 779 host = MockHost()
780 host.filesystem.write_text_file('/tmp/overrides.txt', 'Bug(x) failures/u nexpected/mismatch.html [ ImageOnlyFailure ]\n') 780 host.filesystem.write_text_file('/tmp/overrides.txt', 'Bug(x) failures/u nexpected/mismatch.html [ ImageOnlyFailure ]\n')
781 self.assertTrue(passing_run(['--additional-expectations', '/tmp/override s.txt', 'failures/unexpected/mismatch.html'], 781 self.assertTrue(passing_run(['--additional-expectations', '/tmp/override s.txt', 'failures/unexpected/mismatch.html'],
782 tests_included=True, host=host)) 782 tests_included=True, host=host))
783 783
784 def test_no_http_and_force(self):
785 # See test_run_force, using --force raises an exception.
786 # FIXME: We would like to check the warnings generated.
787 self.assertRaises(ValueError, logging_run, ['--force', '--no-http'])
788
789 @staticmethod 784 @staticmethod
790 def has_test_of_type(tests, type): 785 def has_test_of_type(tests, type):
791 return [test for test in tests if type in test] 786 return [test for test in tests if type in test]
792 787
793 def test_no_http_tests(self):
794 batch_tests_dryrun = get_tests_run(['LayoutTests/http', 'websocket/'])
795 self.assertTrue(RunTest.has_test_of_type(batch_tests_dryrun, 'http'))
796 self.assertTrue(RunTest.has_test_of_type(batch_tests_dryrun, 'websocket' ))
797
798 batch_tests_run_no_http = get_tests_run(['--no-http', 'LayoutTests/http' , 'websocket/'])
799 self.assertFalse(RunTest.has_test_of_type(batch_tests_run_no_http, 'http '))
800 self.assertFalse(RunTest.has_test_of_type(batch_tests_run_no_http, 'webs ocket'))
801
802 batch_tests_run_http = get_tests_run(['--http', 'LayoutTests/http', 'web socket/'])
803 self.assertTrue(RunTest.has_test_of_type(batch_tests_run_http, 'http'))
804 self.assertTrue(RunTest.has_test_of_type(batch_tests_run_http, 'websocke t'))
805
806 def test_platform_directories_ignored_when_searching_for_tests(self): 788 def test_platform_directories_ignored_when_searching_for_tests(self):
807 tests_run = get_tests_run(['--platform', 'test-mac-leopard']) 789 tests_run = get_tests_run(['--platform', 'test-mac-leopard'])
808 self.assertFalse('platform/test-mac-leopard/http/test.html' in tests_run ) 790 self.assertFalse('platform/test-mac-leopard/http/test.html' in tests_run )
809 self.assertFalse('platform/test-win-win7/http/test.html' in tests_run) 791 self.assertFalse('platform/test-win-win7/http/test.html' in tests_run)
810 792
811 def test_platform_directories_not_searched_for_additional_tests(self): 793 def test_platform_directories_not_searched_for_additional_tests(self):
812 tests_run = get_tests_run(['--platform', 'test-mac-leopard', 'http']) 794 tests_run = get_tests_run(['--platform', 'test-mac-leopard', 'http'])
813 self.assertFalse('platform/test-mac-leopard/http/test.html' in tests_run ) 795 self.assertFalse('platform/test-mac-leopard/http/test.html' in tests_run )
814 self.assertFalse('platform/test-win-win7/http/test.html' in tests_run) 796 self.assertFalse('platform/test-win-win7/http/test.html' in tests_run)
815 797
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
990 972
991 run_webkit_tests.run = successful_run 973 run_webkit_tests.run = successful_run
992 res = run_webkit_tests.main(['--platform', 'test'], stdout, stderr) 974 res = run_webkit_tests.main(['--platform', 'test'], stdout, stderr)
993 self.assertEqual(res, -1) 975 self.assertEqual(res, -1)
994 976
995 run_webkit_tests.run = exception_raising_run 977 run_webkit_tests.run = exception_raising_run
996 res = run_webkit_tests.main([], stdout, stderr) 978 res = run_webkit_tests.main([], stdout, stderr)
997 self.assertEqual(res, run_webkit_tests.EXCEPTIONAL_EXIT_STATUS) 979 self.assertEqual(res, run_webkit_tests.EXCEPTIONAL_EXIT_STATUS)
998 finally: 980 finally:
999 run_webkit_tests.run = orig_run_fn 981 run_webkit_tests.run = orig_run_fn
OLDNEW
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698