Improve test coveage of WebProcessMemoryDumpImplTest

third_party/WebKit/Source/platform/web_process_memory_dump_impl_test.cc

Index: third_party/WebKit/Source/platform/web_process_memory_dump_impl_test.cc
diff --git a/third_party/WebKit/Source/platform/web_process_memory_dump_impl_test.cc b/third_party/WebKit/Source/platform/web_process_memory_dump_impl_test.cc
index fafb25bbeb298123fe7d849c1e12cfa5bf7c1afa..7811b67bb4651864a076b019dc8a906bfe44be56 100644
--- a/third_party/WebKit/Source/platform/web_process_memory_dump_impl_test.cc
+++ b/third_party/WebKit/Source/platform/web_process_memory_dump_impl_test.cc
@@ -4,6 +4,8 @@
 
 #include "platform/web_process_memory_dump_impl.h"
 
+#include "base/memory/discardable_memory.h"
+#include "base/test/test_discardable_memory_allocator.h"
 #include "base/trace_event/memory_allocator_dump.h"
 #include "base/trace_event/process_memory_dump.h"
 #include "base/trace_event/trace_event_argument.h"
@@ -119,6 +121,18 @@ TEST(WebProcessMemoryDumpImplTest, IntegrationTest) {
   ASSERT_EQ(wmad4->guid(), allocator_dumps_edges[0].source.ToUint64());
   ASSERT_EQ(guid, allocator_dumps_edges[0].target.ToUint64());
 
+  // Check that createDumpAdapterForSkia() works.
+  auto skia_trace_memory_dump = wpmd1->createDumpAdapterForSkia("1/skia");
+  ASSERT_NE(nullptr, skia_trace_memory_dump);

[Primiano Tucci (use gerrit), 2016/02/29 16:15:28]

IIRC the ASSERT_NE incantation fails to expand properly this and will fail to
compile on some platforms (I hope I am wrong and it got fixed).
IIRC either you ASSERT_NE(static_cast<SkiaBlaBla*>(nullptr), ...) (or
equivalently cast the 2nd to void*)
or more simply ASSERT_TRUE(skia_trace_memory_dump) 

[hajimehoshi, 2016/03/01 10:06:23]

Done. (Used ASSERT_TRUE)

+
+  // Check that createDiscardableMemoryAllocatorDump() works.
+  base::TestDiscardableMemoryAllocator discardable_memory_allocator;
+  auto discardable_memory =
+      discardable_memory_allocator.AllocateLockedDiscardableMemory(1024);
+  wpmd1->createDiscardableMemoryAllocatorDump("1/discardable",
+                                              discardable_memory.get());
+  discardable_memory->Unlock();
+
   wpmd1.reset();
 }