Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 173843003: Avoids minimizing docked window in a unit test (Closed)

Created:
6 years, 10 months ago by varkha
Modified:
6 years, 10 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Avoids minimizing docked window in a unit test. When investigating https://codereview.chromium.org/173443002, sadrul@ noticed that the first window gets minimized after a second window is docked (because there is not enough vertical space). Updated the screen size for this test to ensure it doesn't happen as well as updating the test to explicitly verify that the state is not minimized. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ash/wm/dock/docked_window_resizer_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
varkha
sadrul, Please take a look. This is in place of https://codereview.chromium.org/173133006/. Thanks!
6 years, 10 months ago (2014-02-20 15:32:09 UTC) #1
sadrul
Sweet! Thanks for the quick fix! LGTM
6 years, 10 months ago (2014-02-20 15:34:37 UTC) #2
varkha
The CQ bit was checked by varkha@chromium.org
6 years, 10 months ago (2014-02-20 15:35:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/173843003/1
6 years, 10 months ago (2014-02-20 15:39:03 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 18:59:17 UTC) #5
Message was sent while issue was closed.
Change committed as 252340

Powered by Google App Engine
This is Rietveld 408576698