Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1738313002: [MD settings] converting settings_dialog.css to style-module (Closed)

Created:
4 years, 10 months ago by dschuyler
Modified:
4 years, 10 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] converting settings_dialog.css to style-module This CL moves code around without changing the user UI experience. This removes a deprecated method importing css. BUG=589630 Committed: https://crrev.com/7a0685b625bda20c21d3f59054dd1a03b071b574 Cr-Commit-Position: refs/heads/master@{#378075}

Patch Set 1 : added file #

Messages

Total messages: 15 (8 generated)
dschuyler
4 years, 10 months ago (2016-02-26 22:45:09 UTC) #4
dpapad
The bug linked to the CL seems unrelated. Can you update?
4 years, 10 months ago (2016-02-26 22:49:56 UTC) #6
dschuyler
On 2016/02/26 22:49:56, dpapad wrote: > The bug linked to the CL seems unrelated. Can ...
4 years, 10 months ago (2016-02-27 00:30:11 UTC) #8
dpapad
lgtm
4 years, 10 months ago (2016-02-27 00:47:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738313002/20001
4 years, 10 months ago (2016-02-27 00:53:08 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 10 months ago (2016-02-27 02:07:06 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-27 02:08:05 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a0685b625bda20c21d3f59054dd1a03b071b574
Cr-Commit-Position: refs/heads/master@{#378075}

Powered by Google App Engine
This is Rietveld 408576698