third_party/WebKit/Source/platform/scroll/ScrollAnimator.h - Issue 1738243002: Removed main-thread one dimensional scrolling paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimator.h

Issue 1738243002: Removed main-thread one dimensional scrolling paths. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@removeStepFromUserScroll

Patch Set: Removed TODO that was already fixed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/input/EventHandler.cpp ('K') | « third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm ('k') | third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp » ('j') | third_party/WebKit/Source/platform/scroll/ScrollTypes.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimator.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h

index 4bd57bdb8cd456a96a434e9ee0b66ea9e716c984..adb3f881ea8245d12eff72e09ed34f2d44b23d34 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h

@@ -49,9 +49,9 @@ public:

~ScrollAnimator() override;

bool hasRunningAnimation() const override;

- float computeDeltaToConsume(ScrollbarOrientation, float pixelDelta) const override;

+ FloatSize computeDeltaToConsume(const FloatSize& delta) const override;

- ScrollResultOneDimensional userScroll(ScrollbarOrientation, ScrollGranularity, float delta) override;

+ ScrollResult userScroll(ScrollGranularity, const FloatSize& delta) override;

void scrollToOffsetWithoutAnimation(const FloatPoint&) override;

FloatPoint desiredTargetPosition() const override;