Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 1738243002: Removed main-thread one dimensional scrolling paths. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@removeStepFromUserScroll
Patch Set: Removed TODO that was already fixed Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 Document* documentAtPoint(const IntPoint&); 165 Document* documentAtPoint(const IntPoint&);
166 EphemeralRangeTemplate<EditingAlgorithm<NodeTraversal>> rangeForPoint(const IntPoint& framePoint); 166 EphemeralRangeTemplate<EditingAlgorithm<NodeTraversal>> rangeForPoint(const IntPoint& framePoint);
167 167
168 bool isURLAllowed(const KURL&) const; 168 bool isURLAllowed(const KURL&) const;
169 bool shouldReuseDefaultView(const KURL&) const; 169 bool shouldReuseDefaultView(const KURL&) const;
170 void removeSpellingMarkersUnderWords(const Vector<String>& words); 170 void removeSpellingMarkersUnderWords(const Vector<String>& words);
171 171
172 // FIXME: once scroll customization is enabled everywhere 172 // FIXME: once scroll customization is enabled everywhere
173 // (crbug.com/416862), this should take a ScrollState object. 173 // (crbug.com/416862), this should take a ScrollState object.
174 ScrollResult applyScrollDelta(ScrollGranularity, const FloatSize& delta, boo l isScrollBegin); 174 ScrollResult applyScrollDelta(ScrollGranularity, const FloatSize& delta, boo l isScrollBegin);
175 bool shouldScrollTopControls(const FloatSize& delta) const;
176 175
177 // DisplayItemClient methods 176 // DisplayItemClient methods
178 String debugName() const final { return "LocalFrame"; } 177 String debugName() const final { return "LocalFrame"; }
179 // TODO(chrishtr): fix this. 178 // TODO(chrishtr): fix this.
180 LayoutRect visualRect() const override { return LayoutRect(); } 179 LayoutRect visualRect() const override { return LayoutRect(); }
181 180
182 bool shouldThrottleRendering() const; 181 bool shouldThrottleRendering() const;
183 182
184 // Returns the frame scheduler, creating one if needed. 183 // Returns the frame scheduler, creating one if needed.
185 WebFrameScheduler* frameScheduler(); 184 WebFrameScheduler* frameScheduler();
186 void scheduleVisualUpdateUnlessThrottled(); 185 void scheduleVisualUpdateUnlessThrottled();
187 186
188 void updateSecurityOrigin(SecurityOrigin*); 187 void updateSecurityOrigin(SecurityOrigin*);
189 188
190 bool isNavigationAllowed() const { return m_navigationDisableCount == 0; } 189 bool isNavigationAllowed() const { return m_navigationDisableCount == 0; }
191 190
192 private: 191 private:
193 friend class FrameNavigationDisabler; 192 friend class FrameNavigationDisabler;
194 193
195 LocalFrame(FrameLoaderClient*, FrameHost*, FrameOwner*); 194 LocalFrame(FrameLoaderClient*, FrameHost*, FrameOwner*);
196 195
196 bool shouldScrollTopControls(const FloatSize& delta) const;
197
197 // Internal Frame helper overrides: 198 // Internal Frame helper overrides:
198 WindowProxyManager* windowProxyManager() const override; 199 WindowProxyManager* windowProxyManager() const override;
199 200
200 String localLayerTreeAsText(unsigned flags) const; 201 String localLayerTreeAsText(unsigned flags) const;
201 202
202 // Paints the area for the given rect into a DragImage. 203 // Paints the area for the given rect into a DragImage.
203 // The rect is in the coordinate space of the frame. 204 // The rect is in the coordinate space of the frame.
204 PassOwnPtr<DragImage> paintIntoDragImage(const GlobalPaintFlags, 205 PassOwnPtr<DragImage> paintIntoDragImage(const GlobalPaintFlags,
205 IntRect paintingRect, Node* draggedNode = nullptr, float opacity = 1); 206 IntRect paintingRect, Node* draggedNode = nullptr, float opacity = 1);
206 207
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 explicit FrameNavigationDisabler(LocalFrame&); 318 explicit FrameNavigationDisabler(LocalFrame&);
318 ~FrameNavigationDisabler(); 319 ~FrameNavigationDisabler();
319 320
320 private: 321 private:
321 RawPtrWillBeMember<LocalFrame> m_frame; 322 RawPtrWillBeMember<LocalFrame> m_frame;
322 }; 323 };
323 324
324 } // namespace blink 325 } // namespace blink
325 326
326 #endif // LocalFrame_h 327 #endif // LocalFrame_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698