Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1738)

Unified Diff: content/test/test_render_frame_host.cc

Issue 1738233002: Disallow was_within_same_page = true for a cross-process navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigator_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/test_render_frame_host.cc
diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc
index 0b0a95396ed4f321140da5c8882ea00c78fd6a56..cb587ceaccd6b7deba1a6e1bdfaeeedd5d65e6a7 100644
--- a/content/test/test_render_frame_host.cc
+++ b/content/test/test_render_frame_host.cc
@@ -271,10 +271,12 @@ void TestRenderFrameHost::SendNavigateWithParameters(
ui::PageTransition transition,
int response_code,
const ModificationCallback& callback) {
+ if (!IsBrowserSideNavigationEnabled())
+ OnDidStartLoading(true);
+
// DidStartProvisionalLoad may delete the pending entry that holds |url|,
// so we keep a copy of it to use below.
GURL url_copy(url);
- OnDidStartLoading(true);
OnDidStartProvisionalLoad(url_copy, base::TimeTicks::Now());
FrameHostMsg_DidCommitProvisionalLoad_Params params;
« no previous file with comments | « content/browser/frame_host/navigator_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698