Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 1738233002: Disallow was_within_same_page = true for a cross-process navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 // be a reload, while only a different ref would be in-page (pages can't clear 167 // be a reload, while only a different ref would be in-page (pages can't clear
168 // refs without reload, only change to "#" which we don't count as empty). 168 // refs without reload, only change to "#" which we don't count as empty).
169 // 169 //
170 // The situation is made murkier by history.replaceState(), which could 170 // The situation is made murkier by history.replaceState(), which could
171 // provide the same URL as part of an in-page navigation, not a reload. So 171 // provide the same URL as part of an in-page navigation, not a reload. So
172 // we need to let the (untrustworthy) renderer resolve the ambiguity, but 172 // we need to let the (untrustworthy) renderer resolve the ambiguity, but
173 // only when the URLs are on the same origin. 173 // only when the URLs are on the same origin.
174 bool IsURLInPageNavigation( 174 bool IsURLInPageNavigation(
175 const GURL& url, 175 const GURL& url,
176 bool renderer_says_in_page, 176 bool renderer_says_in_page,
177 RenderFrameHost* rfh) const; 177 RenderFrameHost* rfh,
178 bool will_swap) const;
178 179
179 // Sets the SessionStorageNamespace for the given |partition_id|. This is 180 // Sets the SessionStorageNamespace for the given |partition_id|. This is
180 // used during initialization of a new NavigationController to allow 181 // used during initialization of a new NavigationController to allow
181 // pre-population of the SessionStorageNamespace objects. Session restore, 182 // pre-population of the SessionStorageNamespace objects. Session restore,
182 // prerendering, and the implementaion of window.open() are the primary users 183 // prerendering, and the implementaion of window.open() are the primary users
183 // of this API. 184 // of this API.
184 // 185 //
185 // Calling this function when a SessionStorageNamespace has already been 186 // Calling this function when a SessionStorageNamespace has already been
186 // associated with a |partition_id| will CHECK() fail. 187 // associated with a |partition_id| will CHECK() fail.
187 void SetSessionStorageNamespace( 188 void SetSessionStorageNamespace(
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 TimeSmoother time_smoother_; 444 TimeSmoother time_smoother_;
444 445
445 scoped_ptr<NavigationEntryScreenshotManager> screenshot_manager_; 446 scoped_ptr<NavigationEntryScreenshotManager> screenshot_manager_;
446 447
447 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl); 448 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl);
448 }; 449 };
449 450
450 } // namespace content 451 } // namespace content
451 452
452 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 453 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698