pkg/analyzer/lib/src/task/dart.dart - Issue 1738203002: Prettify ignore syntax (#25685).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 1738203002: Prettify ignore syntax (#25685). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/task/dart.dart

diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart

index d21914cb85c2c5d52f7059e8a606fbcfba664308..4c99474b58b4c133dbd1bfa1e90ba88397bc35c1 100644

--- a/pkg/analyzer/lib/src/task/dart.dart

+++ b/pkg/analyzer/lib/src/task/dart.dart

@@ -2266,7 +2266,7 @@ class DartErrorsTask extends SourceBasedAnalysisTask {

static const String PARSED_UNIT_INPUT = 'PARSED_UNIT_INPUT';

// Prefix for comments ignoring error codes.

- static const String _normalizedIgnorePrefix = '//#ignore:';

+ static const String _normalizedIgnorePrefix = '//ignore:';

Hixie 2016/02/26 18:09:48 Can we have a space after the "//"?

pquitslund 2016/02/26 18:14:54 Yep. Any number of spaces. We remove them before

DartErrorsTask(InternalAnalysisContext context, AnalysisTarget target)

: super(context, target);

« no previous file with comments | « no previous file | pkg/analyzer/test/generated/error_suppression_test.dart » ('j') | no next file with comments »