Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1738203002: Prettify ignore syntax (#25685). (Closed)

Created:
4 years, 10 months ago by pquitslund
Modified:
4 years, 10 months ago
Reviewers:
Hixie, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Prettify ignore syntax (#25685). Prettifies ignore syntax (`//# ignore:` => `//ignore:`). More context: https://github.com/dart-lang/sdk/issues/25685 BUG= R=brianwilkerson@google.com, ianh@google.com Committed: https://github.com/dart-lang/sdk/commit/51188b660192dad2bfed14d53a275639ba9ed8af

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +1 line, -1 line 2 comments Download
M pkg/analyzer/test/generated/error_suppression_test.dart View 11 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pquitslund
4 years, 10 months ago (2016-02-26 18:06:55 UTC) #2
Hixie
lgtm https://codereview.chromium.org/1738203002/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1738203002/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode2269 pkg/analyzer/lib/src/task/dart.dart:2269: static const String _normalizedIgnorePrefix = '//ignore:'; Can we ...
4 years, 10 months ago (2016-02-26 18:09:49 UTC) #3
Hixie
On 2016/02/26 at 18:09:49, Hixie wrote: > lgtm > > https://codereview.chromium.org/1738203002/diff/1/pkg/analyzer/lib/src/task/dart.dart > File pkg/analyzer/lib/src/task/dart.dart (right): ...
4 years, 10 months ago (2016-02-26 18:10:25 UTC) #4
pquitslund
https://codereview.chromium.org/1738203002/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1738203002/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode2269 pkg/analyzer/lib/src/task/dart.dart:2269: static const String _normalizedIgnorePrefix = '//ignore:'; On 2016/02/26 18:09:48, ...
4 years, 10 months ago (2016-02-26 18:14:55 UTC) #5
pquitslund
On 2016/02/26 18:10:25, Hixie wrote: > On 2016/02/26 at 18:09:49, Hixie wrote: > > lgtm ...
4 years, 10 months ago (2016-02-26 18:15:58 UTC) #6
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-26 18:20:10 UTC) #7
pquitslund
4 years, 10 months ago (2016-02-26 18:21:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
51188b660192dad2bfed14d53a275639ba9ed8af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698