Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: net/spdy/spdy_network_transaction_unittest.cc

Issue 17382012: [SPDY] Refactor SpdyStream's handling of response headers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgot to rename a function Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_network_transaction_unittest.cc
diff --git a/net/spdy/spdy_network_transaction_unittest.cc b/net/spdy/spdy_network_transaction_unittest.cc
index b418a3396bb332ae46b1e3fd0a5b1a841e54cee8..bd5433e21d7b2a99b36e55cd69144994f8be5305 100644
--- a/net/spdy/spdy_network_transaction_unittest.cc
+++ b/net/spdy/spdy_network_transaction_unittest.cc
@@ -6185,11 +6185,7 @@ TEST_P(SpdyNetworkTransactionTest, ServerPushWithTwoHeaderFrames) {
ReadResult(trans, &data, &result);
// Verify that the received push data is same as the expected push data.
- EXPECT_EQ(result2.compare(expected_push_result), 0)
- << "Received data: "
- << result2
- << "||||| Expected data: "
- << expected_push_result;
Ryan Hamilton 2013/06/19 18:58:36 nit: are you sure you don't want to keep this extr
akalin 2013/06/21 21:13:25 The same data is already logged by EXPECT_EQ, sinc
+ EXPECT_EQ(expected_push_result, result2);
// Verify the SYN_REPLY.
// Copy the response info, because trans goes away.

Powered by Google App Engine
This is Rietveld 408576698