Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: net/spdy/spdy_stream_test_util.cc

Issue 17382012: [SPDY] Refactor SpdyStream's handling of response headers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgot to rename a function Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_stream_test_util.h" 5 #include "net/spdy/spdy_stream_test_util.h"
6 6
7 #include <cstddef> 7 #include <cstddef>
8 8
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "net/base/completion_callback.h" 10 #include "net/base/completion_callback.h"
11 #include "net/spdy/spdy_stream.h" 11 #include "net/spdy/spdy_stream.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 13
14 namespace net { 14 namespace net {
15 15
16 namespace test { 16 namespace test {
17 17
18 ClosingDelegate::ClosingDelegate( 18 ClosingDelegate::ClosingDelegate(
19 const base::WeakPtr<SpdyStream>& stream) : stream_(stream) {} 19 const base::WeakPtr<SpdyStream>& stream) : stream_(stream) {}
20 20
21 ClosingDelegate::~ClosingDelegate() {} 21 ClosingDelegate::~ClosingDelegate() {}
22 22
23 void ClosingDelegate::OnRequestHeadersSent() {} 23 void ClosingDelegate::OnRequestHeadersSent() {}
24 24
25 int ClosingDelegate::OnResponseHeadersReceived(const SpdyHeaderBlock& response, 25 int ClosingDelegate::OnResponseHeadersUpdated(
26 base::Time response_time, 26 const SpdyHeaderBlock& response_headers) {
27 int status) {
28 return OK; 27 return OK;
29 } 28 }
30 29
31 int ClosingDelegate::OnDataReceived(scoped_ptr<SpdyBuffer> buffer) { 30 int ClosingDelegate::OnDataReceived(scoped_ptr<SpdyBuffer> buffer) {
32 return OK; 31 return OK;
33 } 32 }
34 33
35 void ClosingDelegate::OnDataSent() {} 34 void ClosingDelegate::OnDataSent() {}
36 35
37 void ClosingDelegate::OnClose(int status) { 36 void ClosingDelegate::OnClose(int status) {
(...skipping 11 matching lines...) Expand all
49 48
50 StreamDelegateBase::~StreamDelegateBase() { 49 StreamDelegateBase::~StreamDelegateBase() {
51 } 50 }
52 51
53 void StreamDelegateBase::OnRequestHeadersSent() { 52 void StreamDelegateBase::OnRequestHeadersSent() {
54 stream_id_ = stream_->stream_id(); 53 stream_id_ = stream_->stream_id();
55 EXPECT_NE(stream_id_, 0u); 54 EXPECT_NE(stream_id_, 0u);
56 send_headers_completed_ = true; 55 send_headers_completed_ = true;
57 } 56 }
58 57
59 int StreamDelegateBase::OnResponseHeadersReceived( 58 int StreamDelegateBase::OnResponseHeadersUpdated(
60 const SpdyHeaderBlock& response, 59 const SpdyHeaderBlock& response_headers) {
61 base::Time response_time,
62 int status) {
63 EXPECT_TRUE(send_headers_completed_); 60 EXPECT_TRUE(send_headers_completed_);
64 response_ = response; 61 response_ = response_headers;
65 return status; 62 return OK;
66 } 63 }
67 64
68 int StreamDelegateBase::OnDataReceived(scoped_ptr<SpdyBuffer> buffer) { 65 int StreamDelegateBase::OnDataReceived(scoped_ptr<SpdyBuffer> buffer) {
69 if (buffer) 66 if (buffer)
70 received_data_queue_.Enqueue(buffer.Pass()); 67 received_data_queue_.Enqueue(buffer.Pass());
71 return OK; 68 return OK;
72 } 69 }
73 70
74 void StreamDelegateBase::OnDataSent() {} 71 void StreamDelegateBase::OnDataSent() {}
75 72
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 110
114 StreamDelegateSendImmediate::StreamDelegateSendImmediate( 111 StreamDelegateSendImmediate::StreamDelegateSendImmediate(
115 const base::WeakPtr<SpdyStream>& stream, 112 const base::WeakPtr<SpdyStream>& stream,
116 base::StringPiece data) 113 base::StringPiece data)
117 : StreamDelegateBase(stream), 114 : StreamDelegateBase(stream),
118 data_(data) {} 115 data_(data) {}
119 116
120 StreamDelegateSendImmediate::~StreamDelegateSendImmediate() { 117 StreamDelegateSendImmediate::~StreamDelegateSendImmediate() {
121 } 118 }
122 119
123 int StreamDelegateSendImmediate::OnResponseHeadersReceived( 120 int StreamDelegateSendImmediate::OnResponseHeadersUpdated(
124 const SpdyHeaderBlock& response, 121 const SpdyHeaderBlock& response_headers) {
125 base::Time response_time, 122 int status = StreamDelegateBase::OnResponseHeadersUpdated(response_headers);
126 int status) {
127 status =
128 StreamDelegateBase::OnResponseHeadersReceived(
129 response, response_time, status);
130 if (data_.data()) { 123 if (data_.data()) {
131 scoped_refptr<StringIOBuffer> buf(new StringIOBuffer(data_.as_string())); 124 scoped_refptr<StringIOBuffer> buf(new StringIOBuffer(data_.as_string()));
132 stream()->SendData(buf.get(), buf->size(), MORE_DATA_TO_SEND); 125 stream()->SendData(buf.get(), buf->size(), MORE_DATA_TO_SEND);
133 } 126 }
134 return status; 127 return status;
135 } 128 }
136 129
137 StreamDelegateWithBody::StreamDelegateWithBody( 130 StreamDelegateWithBody::StreamDelegateWithBody(
138 const base::WeakPtr<SpdyStream>& stream, 131 const base::WeakPtr<SpdyStream>& stream,
139 base::StringPiece data) 132 base::StringPiece data)
140 : StreamDelegateBase(stream), 133 : StreamDelegateBase(stream),
141 buf_(new StringIOBuffer(data.as_string())) {} 134 buf_(new StringIOBuffer(data.as_string())) {}
142 135
143 StreamDelegateWithBody::~StreamDelegateWithBody() { 136 StreamDelegateWithBody::~StreamDelegateWithBody() {
144 } 137 }
145 138
146 void StreamDelegateWithBody::OnRequestHeadersSent() { 139 void StreamDelegateWithBody::OnRequestHeadersSent() {
147 StreamDelegateBase::OnRequestHeadersSent(); 140 StreamDelegateBase::OnRequestHeadersSent();
148 stream()->SendData(buf_.get(), buf_->size(), NO_MORE_DATA_TO_SEND); 141 stream()->SendData(buf_.get(), buf_->size(), NO_MORE_DATA_TO_SEND);
149 } 142 }
150 143
151 } // namespace test 144 } // namespace test
152 145
153 } // namespace net 146 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698