chrome/browser/ui/unload_controller.cc - Issue 17382005: Unbreak tabs.onRemove extension API in face of fast tab closure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/unload_controller.cc

Issue 17382005: Unbreak tabs.onRemove extension API in face of fast tab closure Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/unload_controller.cc

diff --git a/chrome/browser/ui/unload_controller.cc b/chrome/browser/ui/unload_controller.cc

index b52348c30ae25d9568f6c3ea1fb7967e96ca1f00..2a400fe0b0dcc42595ddc0c6c0374a1ea9a0ed82 100644

--- a/chrome/browser/ui/unload_controller.cc

+++ b/chrome/browser/ui/unload_controller.cc

@@ -220,6 +220,7 @@ bool UnloadController::DetachWebContents(content::WebContents* contents) {

if (index != TabStripModel::kNoTab &&

contents->NeedToFireBeforeUnload()) {

tabs_needing_unload_ack_.insert(contents);

+ contents->OnUnloadAboutToDetach();

browser_->tab_strip_model()->DetachWebContentsAt(index);

contents->SetDelegate(detached_delegate_.get());

contents->OnUnloadDetachedStarted();