Unbreak tabs.onRemove extension API in face of fast tab closure

chrome/browser/extensions/browser_event_router.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/browser_event_router.h"
 
 #include "base/json/json_writer.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/extension_action/extension_page_actions_api_constants.h"
 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
@@ skipping 199 matching lines @@
       index));
   args->Append(object_args);
 
   Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext());
   DispatchEvent(profile, events::kOnTabAttached, args.Pass(),
                 EventRouter::USER_GESTURE_UNKNOWN);
 }
 
 void BrowserEventRouter::TabDetachedAt(WebContents* contents, int index) {
   if (!GetTabEntry(contents)) {
-    // The tab was removed. Don't send detach event.
+    // The tab was removed. Don't send detach/remove event.
     return;
   }
 
-  scoped_ptr<ListValue> args(new ListValue());
-  args->Append(Value::CreateIntegerValue(ExtensionTabUtil::GetTabId(contents)));
-
-  DictionaryValue* object_args = new DictionaryValue();
-  object_args->Set(tab_keys::kOldWindowIdKey, Value::CreateIntegerValue(
-      ExtensionTabUtil::GetWindowIdOfTab(contents)));
-  object_args->Set(tab_keys::kOldPositionKey, Value::CreateIntegerValue(
-      index));
-  args->Append(object_args);
-
-  Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext());
-  DispatchEvent(profile, events::kOnTabDetached, args.Pass(),
-                EventRouter::USER_GESTURE_UNKNOWN);
+  // If this detach is occuring as part of the process of closing |contents|
+  // then dispatch a remove event rather than a detach event.
+  if (contents->GetWebContentsDetachedToClose()) {
+    int tab_id = ExtensionTabUtil::GetTabId(contents);
+    // TODO BEFORE COMITTING: pass tab_strip_model->closing_all() as last
+    // parameter.
+    DispatchTabRemovedAndUnregisterNotifications(contents, tab_id, false);
+  } else {
+    DispatchTabDetached(contents, index);
+  }
 }
 
 void BrowserEventRouter::TabClosingAt(TabStripModel* tab_strip_model,
                                       WebContents* contents,
                                       int index) {
   int tab_id = ExtensionTabUtil::GetTabId(contents);
-
-  scoped_ptr<ListValue> args(new ListValue());
-  args->Append(Value::CreateIntegerValue(tab_id));
-
-  DictionaryValue* object_args = new DictionaryValue();
-  object_args->SetInteger(tab_keys::kWindowIdKey,
-                          ExtensionTabUtil::GetWindowIdOfTab(contents));
-  object_args->SetBoolean(tab_keys::kWindowClosing,
-                          tab_strip_model->closing_all());
-  args->Append(object_args);
-
-  Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext());
-  DispatchEvent(profile, events::kOnTabRemoved, args.Pass(),
-                EventRouter::USER_GESTURE_UNKNOWN);
-
-  int removed_count = tab_entries_.erase(tab_id);
-  DCHECK_GT(removed_count, 0);
-
-  UnregisterForTabNotifications(contents);
+  DispatchTabRemovedAndUnregisterNotifications(contents, tab_id,
+      tab_strip_model->closing_all());
 }
 
 void BrowserEventRouter::ActiveTabChanged(WebContents* old_contents,
                                           WebContents* new_contents,
                                           int index,
                                           int reason) {
   scoped_ptr<ListValue> args(new ListValue());
   int tab_id = ExtensionTabUtil::GetTabId(new_contents);
   args->Append(Value::CreateIntegerValue(tab_id));
 
@@ skipping 199 matching lines @@
 
 BrowserEventRouter::TabEntry* BrowserEventRouter::GetTabEntry(
     const WebContents* contents) {
   int tab_id = ExtensionTabUtil::GetTabId(contents);
   std::map<int, TabEntry>::iterator i = tab_entries_.find(tab_id);
   if (tab_entries_.end() == i)
     return NULL;
   return &i->second;
 }
 
+void BrowserEventRouter::DispatchTabDetached(WebContents* contents,
+      int index) {
+  scoped_ptr<ListValue> args(new ListValue());
+  args->Append(Value::CreateIntegerValue(ExtensionTabUtil::GetTabId(contents)));
+
+  DictionaryValue* object_args = new DictionaryValue();
+  object_args->Set(tab_keys::kOldWindowIdKey, Value::CreateIntegerValue(
+      ExtensionTabUtil::GetWindowIdOfTab(contents)));
+  object_args->Set(tab_keys::kOldPositionKey, Value::CreateIntegerValue(
+      index));
+  args->Append(object_args);
+
+  Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext());
+  DispatchEvent(profile, events::kOnTabDetached, args.Pass(),
+                EventRouter::USER_GESTURE_UNKNOWN);
+}
+
+void BrowserEventRouter::DispatchTabRemovedAndUnregisterNotifications(
+      WebContents* contents, int tab_id, bool window_closing) {
+  scoped_ptr<ListValue> args(new ListValue());
+  args->Append(Value::CreateIntegerValue(tab_id));
+
+  DictionaryValue* object_args = new DictionaryValue();
+  object_args->SetInteger(tab_keys::kWindowIdKey,
+                          ExtensionTabUtil::GetWindowIdOfTab(contents));
+  object_args->SetBoolean(tab_keys::kWindowClosing,
+                          window_closing);
+  args->Append(object_args);
+
+  Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext());
+  DispatchEvent(profile, events::kOnTabRemoved, args.Pass(),
+                EventRouter::USER_GESTURE_UNKNOWN);
+
+  int removed_count = tab_entries_.erase(tab_id);
+  DCHECK_GT(removed_count, 0);
+  UnregisterForTabNotifications(contents);
+}
+
 void BrowserEventRouter::Observe(int type,
                                  const content::NotificationSource& source,
                                  const content::NotificationDetails& details) {
   if (type == content::NOTIFICATION_NAV_ENTRY_COMMITTED) {
     NavigationController* source_controller =
         content::Source<NavigationController>(source).ptr();
     TabUpdated(source_controller->GetWebContents(), true);
   } else if (type == content::NOTIFICATION_WEB_CONTENTS_DESTROYED) {
     // Tab was destroyed after being detached (without being re-attached).
     WebContents* contents = content::Source<WebContents>(source).ptr();
@@ skipping 148 matching lines @@
 
     DispatchEventToExtension(profile,
                              extension_action.extension_id(),
                              event_name,
                              args.Pass(),
                              EventRouter::USER_GESTURE_ENABLED);
   }
 }
 
 }  // namespace extensions