Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: src/objects-inl.h

Issue 1738153002: [turbofan] Don't use the CompareIC in JSGenericLowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Consistent SIMD.js equality Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips64/code-stubs-mips64.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 1335 matching lines...) Expand 10 before | Expand all | Expand 10 after
1346 kExponentShift) - kExponentBias; 1346 kExponentShift) - kExponentBias;
1347 } 1347 }
1348 1348
1349 1349
1350 int HeapNumber::get_sign() { 1350 int HeapNumber::get_sign() {
1351 return READ_INT_FIELD(this, kExponentOffset) & kSignMask; 1351 return READ_INT_FIELD(this, kExponentOffset) & kSignMask;
1352 } 1352 }
1353 1353
1354 1354
1355 bool Simd128Value::Equals(Simd128Value* that) { 1355 bool Simd128Value::Equals(Simd128Value* that) {
1356 // TODO(bmeurer): This doesn't match the SIMD.js specification, but it seems
1357 // to be consistent with what the CompareICStub does, and what is tested in
1358 // the current SIMD.js testsuite.
1359 if (this == that) return true;
1356 #define SIMD128_VALUE(TYPE, Type, type, lane_count, lane_type) \ 1360 #define SIMD128_VALUE(TYPE, Type, type, lane_count, lane_type) \
1357 if (this->Is##Type()) { \ 1361 if (this->Is##Type()) { \
1358 if (!that->Is##Type()) return false; \ 1362 if (!that->Is##Type()) return false; \
1359 return Type::cast(this)->Equals(Type::cast(that)); \ 1363 return Type::cast(this)->Equals(Type::cast(that)); \
1360 } 1364 }
1361 SIMD128_TYPES(SIMD128_VALUE) 1365 SIMD128_TYPES(SIMD128_VALUE)
1362 #undef SIMD128_VALUE 1366 #undef SIMD128_VALUE
1363 return false; 1367 return false;
1364 } 1368 }
1365 1369
(...skipping 6389 matching lines...) Expand 10 before | Expand all | Expand 10 after
7755 #undef WRITE_INT64_FIELD 7759 #undef WRITE_INT64_FIELD
7756 #undef READ_BYTE_FIELD 7760 #undef READ_BYTE_FIELD
7757 #undef WRITE_BYTE_FIELD 7761 #undef WRITE_BYTE_FIELD
7758 #undef NOBARRIER_READ_BYTE_FIELD 7762 #undef NOBARRIER_READ_BYTE_FIELD
7759 #undef NOBARRIER_WRITE_BYTE_FIELD 7763 #undef NOBARRIER_WRITE_BYTE_FIELD
7760 7764
7761 } // namespace internal 7765 } // namespace internal
7762 } // namespace v8 7766 } // namespace v8
7763 7767
7764 #endif // V8_OBJECTS_INL_H_ 7768 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/mips64/code-stubs-mips64.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698