Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: src/ia32/code-stubs-ia32.cc

Issue 1738153002: [turbofan] Don't use the CompareIC in JSGenericLowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Consistent SIMD.js equality Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/bootstrapper.h" 8 #include "src/bootstrapper.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1429 matching lines...) Expand 10 before | Expand all | Expand 10 after
1440 __ Move(eax, Immediate(EQUAL)); 1440 __ Move(eax, Immediate(EQUAL));
1441 __ ret(0); // eax, edx were pushed 1441 __ ret(0); // eax, edx were pushed
1442 } 1442 }
1443 __ bind(&runtime_call); 1443 __ bind(&runtime_call);
1444 1444
1445 if (cc == equal) { 1445 if (cc == equal) {
1446 { 1446 {
1447 FrameScope scope(masm, StackFrame::INTERNAL); 1447 FrameScope scope(masm, StackFrame::INTERNAL);
1448 __ Push(edx); 1448 __ Push(edx);
1449 __ Push(eax); 1449 __ Push(eax);
1450 __ CallRuntime(strict() ? Runtime::kStrictEquals : Runtime::kEquals); 1450 __ CallRuntime(strict() ? Runtime::kStrictEqual : Runtime::kEqual);
1451 } 1451 }
1452 // Turn true into 0 and false into some non-zero value. 1452 // Turn true into 0 and false into some non-zero value.
1453 STATIC_ASSERT(EQUAL == 0); 1453 STATIC_ASSERT(EQUAL == 0);
1454 __ sub(eax, Immediate(isolate()->factory()->true_value())); 1454 __ sub(eax, Immediate(isolate()->factory()->true_value()));
1455 __ Ret(); 1455 __ Ret();
1456 } else { 1456 } else {
1457 // Push arguments below the return address. 1457 // Push arguments below the return address.
1458 __ pop(ecx); 1458 __ pop(ecx);
1459 __ push(edx); 1459 __ push(edx);
1460 __ push(eax); 1460 __ push(eax);
(...skipping 4461 matching lines...) Expand 10 before | Expand all | Expand 10 after
5922 return_value_operand, NULL); 5922 return_value_operand, NULL);
5923 } 5923 }
5924 5924
5925 5925
5926 #undef __ 5926 #undef __
5927 5927
5928 } // namespace internal 5928 } // namespace internal
5929 } // namespace v8 5929 } // namespace v8
5930 5930
5931 #endif // V8_TARGET_ARCH_IA32 5931 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698