third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp - Issue 1738133002: Add support for media attribute on link

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

Issue 1738133002: Add support for media attribute on link (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp ('k') | third_party/WebKit/Source/core/loader/DocumentLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

index 8e093f963ada4c832ae84ce1a8c42642e8bf9e98..00f6ea3e7946fcf3123fe194005ac4aef3a2ac91 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

@@ -143,7 +143,7 @@ protected:

MockHTMLResourcePreloader preloader;

KURL baseURL(ParsedURLString, testCase.baseURL);

m_scanner->appendToEnd(String(testCase.inputHTML));

- m_scanner->scan(&preloader, baseURL);

+ m_scanner->scan(&preloader, baseURL, nullptr);

preloader.preloadRequestVerification(testCase.type, testCase.preloadedURL, testCase.outputBaseURL, testCase.resourceWidth, testCase.preferences);

}

@@ -153,7 +153,7 @@ protected:

MockHTMLResourcePreloader preloader;

KURL baseURL(ParsedURLString, testCase.baseURL);

m_scanner->appendToEnd(String(testCase.inputHTML));

- m_scanner->scan(&preloader, baseURL);

+ m_scanner->scan(&preloader, baseURL, nullptr);

preloader.preconnectRequestVerification(testCase.preconnectedHost, testCase.crossOrigin);

}

@@ -162,7 +162,7 @@ protected:

MockHTMLResourcePreloader preloader;

KURL baseURL(ParsedURLString, testCase.baseURL);

m_scanner->appendToEnd(String(testCase.inputHTML));

- m_scanner->scan(&preloader, baseURL);

+ m_scanner->scan(&preloader, baseURL, nullptr);

preloader.preloadRequestVerification(testCase.type, testCase.preloadedURL, testCase.outputBaseURL, testCase.resourceWidth, testCase.referrerPolicy);

}