third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h - Issue 1738133002: Add support for media attribute on link

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h

Issue 1738133002: Add support for media attribute on link (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp ('k') | third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h

index 6c83f39042d35ce2562bfb78fd625622f11b28a9..3e493518f557ecd9e62424cd39c6e4bb24c2258e 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h

+++ b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h

@@ -45,6 +45,15 @@ class HTMLParserOptions;

class HTMLTokenizer;

class SegmentedString;

+struct ViewportDescriptionWrapper {

+ ViewportDescription description;

+ bool set;

+ ViewportDescriptionWrapper()

+ : set(false)

+ {

+ }

+};

struct CORE_EXPORT CachedDocumentParameters {

USING_FAST_MALLOC(CachedDocumentParameters);

public:

@@ -69,8 +78,8 @@ public:

TokenPreloadScanner(const KURL& documentURL, PassOwnPtr<CachedDocumentParameters>, const MediaValuesCached::MediaValuesCachedData&);

~TokenPreloadScanner();

- void scan(const HTMLToken&, const SegmentedString&, PreloadRequestStream& requests);

- void scan(const CompactHTMLToken&, const SegmentedString&, PreloadRequestStream& requests);

+ void scan(const HTMLToken&, const SegmentedString&, PreloadRequestStream& requests, ViewportDescriptionWrapper*);

+ void scan(const CompactHTMLToken&, const SegmentedString&, PreloadRequestStream& requests, ViewportDescriptionWrapper*);

void setPredictedBaseElementURL(const KURL& url) { m_predictedBaseElementURL = url; }

@@ -83,7 +92,7 @@ private:

class StartTagScanner;

template <typename Token>

- inline void scanCommon(const Token&, const SegmentedString&, PreloadRequestStream& requests);

+ inline void scanCommon(const Token&, const SegmentedString&, PreloadRequestStream& requests, ViewportDescriptionWrapper*);

template<typename Token>

void updatePredictedBaseURL(const Token&);

@@ -146,7 +155,7 @@ public:

~HTMLPreloadScanner();

void appendToEnd(const SegmentedString&);

- void scan(ResourcePreloader*, const KURL& documentBaseElementURL);

+ void scan(ResourcePreloader*, const KURL& documentBaseElementURL, ViewportDescriptionWrapper*);

private:

HTMLPreloadScanner(const HTMLParserOptions&, const KURL& documentURL, PassOwnPtr<CachedDocumentParameters>, const MediaValuesCached::MediaValuesCachedData&);