Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp

Issue 1738133002: Add support for media attribute on link (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/loader/LinkLoader.h" 5 #include "core/loader/LinkLoader.h"
6 6
7 #include "core/fetch/MemoryCache.h" 7 #include "core/fetch/MemoryCache.h"
8 #include "core/fetch/ResourceFetcher.h" 8 #include "core/fetch/ResourceFetcher.h"
9 #include "core/frame/Settings.h" 9 #include "core/frame/Settings.h"
10 #include "core/html/LinkRelAttribute.h" 10 #include "core/html/LinkRelAttribute.h"
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 mutable bool m_isCrossOrigin; 81 mutable bool m_isCrossOrigin;
82 82
83 }; 83 };
84 84
85 TEST(LinkLoaderTest, Preload) 85 TEST(LinkLoaderTest, Preload)
86 { 86 {
87 struct TestCase { 87 struct TestCase {
88 const char* href; 88 const char* href;
89 const char* as; 89 const char* as;
90 const char* type; 90 const char* type;
91 const char* media;
91 const ResourceLoadPriority priority; 92 const ResourceLoadPriority priority;
92 const WebURLRequest::RequestContext context; 93 const WebURLRequest::RequestContext context;
93 const bool linkLoaderShouldLoadValue; 94 const bool linkLoaderShouldLoadValue;
94 const bool expectingLoad; 95 const bool expectingLoad;
95 const char* accept; 96 const char* accept;
96 } cases[] = { 97 } cases[] = {
97 {"data://example.test/cat.jpg", "image", "", ResourceLoadPriorityVeryLow , WebURLRequest::RequestContextImage, true, true, "image/webp,image/*,*/*;q=0.8" }, 98 {"data://example.test/cat.jpg", "image", "", "", ResourceLoadPriorityVer yLow, WebURLRequest::RequestContextImage, true, true, "image/webp,image/*,*/*;q= 0.8"},
98 {"data://example.test/cat.js", "script", "", ResourceLoadPriorityMedium, WebURLRequest::RequestContextScript, true, true, "*/*"}, 99 {"data://example.test/cat.js", "script", "", "", ResourceLoadPriorityMed ium, WebURLRequest::RequestContextScript, true, true, "*/*"},
99 {"data://example.test/cat.css", "style", "", ResourceLoadPriorityHigh, W ebURLRequest::RequestContextStyle, true, true, "text/css,*/*;q=0.1"}, 100 {"data://example.test/cat.css", "style", "", "", ResourceLoadPriorityHig h, WebURLRequest::RequestContextStyle, true, true, "text/css,*/*;q=0.1"},
100 // TODO(yoav): It doesn't seem like the audio context is ever used. That should probably be fixed (or we can consolidate audio and video). 101 // TODO(yoav): It doesn't seem like the audio context is ever used. That should probably be fixed (or we can consolidate audio and video).
101 {"data://example.test/cat.wav", "audio", "", ResourceLoadPriorityLow, We bURLRequest::RequestContextVideo, true, true, ""}, 102 {"data://example.test/cat.wav", "audio", "", "", ResourceLoadPriorityLow , WebURLRequest::RequestContextVideo, true, true, ""},
102 {"data://example.test/cat.mp4", "video", "", ResourceLoadPriorityLow, We bURLRequest::RequestContextVideo, true, true, ""}, 103 {"data://example.test/cat.mp4", "video", "", "", ResourceLoadPriorityLow , WebURLRequest::RequestContextVideo, true, true, ""},
103 {"data://example.test/cat.vtt", "track", "", ResourceLoadPriorityLow, We bURLRequest::RequestContextTrack, true, true, ""}, 104 {"data://example.test/cat.vtt", "track", "", "", ResourceLoadPriorityLow , WebURLRequest::RequestContextTrack, true, true, ""},
104 {"data://example.test/cat.woff", "font", "", ResourceLoadPriorityMedium, WebURLRequest::RequestContextFont, true, true, ""}, 105 {"data://example.test/cat.woff", "font", "", "", ResourceLoadPriorityMed ium, WebURLRequest::RequestContextFont, true, true, ""},
105 // TODO(yoav): subresource should be *very* low priority (rather than lo w). 106 // TODO(yoav): subresource should be *very* low priority (rather than lo w).
106 {"data://example.test/cat.empty", "", "", ResourceLoadPriorityLow, WebUR LRequest::RequestContextSubresource, true, true, ""}, 107 {"data://example.test/cat.empty", "", "", "", ResourceLoadPriorityLow, W ebURLRequest::RequestContextSubresource, true, true, ""},
107 {"data://example.test/cat.blob", "blabla", "", ResourceLoadPriorityLow, WebURLRequest::RequestContextSubresource, false, false, ""}, 108 {"data://example.test/cat.blob", "blabla", "", "", ResourceLoadPriorityL ow, WebURLRequest::RequestContextSubresource, false, false, ""},
108 {"bla://example.test/cat.gif", "image", "", ResourceLoadPriorityUnresolv ed, WebURLRequest::RequestContextImage, false, false, ""}, 109 {"bla://example.test/cat.gif", "image", "", "", ResourceLoadPriorityUnre solved, WebURLRequest::RequestContextImage, false, false, ""},
109 // MIME type tests 110 // MIME type tests
110 {"data://example.test/cat.webp", "image", "image/webp", ResourceLoadPrio rityVeryLow, WebURLRequest::RequestContextImage, true, true, "image/webp,image/* ,*/*;q=0.8"}, 111 {"data://example.test/cat.webp", "image", "image/webp", "", ResourceLoad PriorityVeryLow, WebURLRequest::RequestContextImage, true, true, "image/webp,ima ge/*,*/*;q=0.8"},
111 {"data://example.test/cat.svg", "image", "image/svg+xml", ResourceLoadPr iorityVeryLow, WebURLRequest::RequestContextImage, true, true, "image/webp,image /*,*/*;q=0.8"}, 112 {"data://example.test/cat.svg", "image", "image/svg+xml", "", ResourceLo adPriorityVeryLow, WebURLRequest::RequestContextImage, true, true, "image/webp,i mage/*,*/*;q=0.8"},
112 {"data://example.test/cat.jxr", "image", "image/jxr", ResourceLoadPriori tyUnresolved, WebURLRequest::RequestContextImage, false, false, ""}, 113 {"data://example.test/cat.jxr", "image", "image/jxr", "", ResourceLoadPr iorityUnresolved, WebURLRequest::RequestContextImage, false, false, ""},
113 {"data://example.test/cat.js", "script", "text/javascript", ResourceLoad PriorityMedium, WebURLRequest::RequestContextScript, true, true, "*/*"}, 114 {"data://example.test/cat.js", "script", "text/javascript", "", Resource LoadPriorityMedium, WebURLRequest::RequestContextScript, true, true, "*/*"},
114 {"data://example.test/cat.js", "script", "text/coffeescript", ResourceLo adPriorityUnresolved, WebURLRequest::RequestContextScript, false, false, ""}, 115 {"data://example.test/cat.js", "script", "text/coffeescript", "", Resour ceLoadPriorityUnresolved, WebURLRequest::RequestContextScript, false, false, ""} ,
115 {"data://example.test/cat.css", "style", "text/css", ResourceLoadPriorit yHigh, WebURLRequest::RequestContextStyle, true, true, "text/css,*/*;q=0.1"}, 116 {"data://example.test/cat.css", "style", "text/css", "", ResourceLoadPri orityHigh, WebURLRequest::RequestContextStyle, true, true, "text/css,*/*;q=0.1"} ,
116 {"data://example.test/cat.css", "style", "text/sass", ResourceLoadPriori tyUnresolved, WebURLRequest::RequestContextStyle, false, false, ""}, 117 {"data://example.test/cat.css", "style", "text/sass", "", ResourceLoadPr iorityUnresolved, WebURLRequest::RequestContextStyle, false, false, ""},
117 {"data://example.test/cat.wav", "audio", "audio/wav", ResourceLoadPriori tyLow, WebURLRequest::RequestContextVideo, true, true, ""}, 118 {"data://example.test/cat.wav", "audio", "audio/wav", "", ResourceLoadPr iorityLow, WebURLRequest::RequestContextVideo, true, true, ""},
118 {"data://example.test/cat.wav", "audio", "audio/mp57", ResourceLoadPrior ityUnresolved, WebURLRequest::RequestContextVideo, false, false, ""}, 119 {"data://example.test/cat.wav", "audio", "audio/mp57", "", ResourceLoadP riorityUnresolved, WebURLRequest::RequestContextVideo, false, false, ""},
119 {"data://example.test/cat.webm", "video", "video/webm", ResourceLoadPrio rityLow, WebURLRequest::RequestContextVideo, true, true, ""}, 120 {"data://example.test/cat.webm", "video", "video/webm", "", ResourceLoad PriorityLow, WebURLRequest::RequestContextVideo, true, true, ""},
120 {"data://example.test/cat.mp199", "video", "video/mp199", ResourceLoadPr iorityUnresolved, WebURLRequest::RequestContextVideo, false, false, ""}, 121 {"data://example.test/cat.mp199", "video", "video/mp199", "", ResourceLo adPriorityUnresolved, WebURLRequest::RequestContextVideo, false, false, ""},
121 {"data://example.test/cat.vtt", "track", "text/vtt", ResourceLoadPriorit yLow, WebURLRequest::RequestContextTrack, true, true, ""}, 122 {"data://example.test/cat.vtt", "track", "text/vtt", "", ResourceLoadPri orityLow, WebURLRequest::RequestContextTrack, true, true, ""},
122 {"data://example.test/cat.vtt", "track", "text/subtitlething", ResourceL oadPriorityUnresolved, WebURLRequest::RequestContextTrack, false, false, ""}, 123 {"data://example.test/cat.vtt", "track", "text/subtitlething", "", Resou rceLoadPriorityUnresolved, WebURLRequest::RequestContextTrack, false, false, ""} ,
123 {"data://example.test/cat.woff", "font", "font/woff2", ResourceLoadPrior ityMedium, WebURLRequest::RequestContextFont, true, true, ""}, 124 {"data://example.test/cat.woff", "font", "font/woff2", "", ResourceLoadP riorityMedium, WebURLRequest::RequestContextFont, true, true, ""},
124 {"data://example.test/cat.woff", "font", "font/woff84", ResourceLoadPrio rityUnresolved, WebURLRequest::RequestContextFont, false, false, ""}, 125 {"data://example.test/cat.woff", "font", "font/woff84", "", ResourceLoad PriorityUnresolved, WebURLRequest::RequestContextFont, false, false, ""},
125 {"data://example.test/cat.empty", "", "foo/bar", ResourceLoadPriorityLow , WebURLRequest::RequestContextSubresource, true, true, ""}, 126 {"data://example.test/cat.empty", "", "foo/bar", "", ResourceLoadPriorit yLow, WebURLRequest::RequestContextSubresource, true, true, ""},
126 {"data://example.test/cat.blob", "blabla", "foo/bar", ResourceLoadPriori tyLow, WebURLRequest::RequestContextSubresource, false, false, ""}, 127 {"data://example.test/cat.blob", "blabla", "foo/bar", "", ResourceLoadPr iorityLow, WebURLRequest::RequestContextSubresource, false, false, ""},
128 // Media tests
129 {"data://example.test/cat.gif", "image", "", "(max-width: 600px)", Resou rceLoadPriorityVeryLow, WebURLRequest::RequestContextImage, true, true, "image/w ebp,image/*,*/*;q=0.8"},
130 {"data://example.test/cat.gif", "image", "", "(max-width: 400px)", Resou rceLoadPriorityUnresolved, WebURLRequest::RequestContextImage, true, false, ""},
131 {"data://example.test/cat.gif", "image", "", "(max-width: 600px)", Resou rceLoadPriorityVeryLow, WebURLRequest::RequestContextImage, false, false, "image /webp,image/*,*/*;q=0.8"},
127 }; 132 };
128 133
129 // Test the cases with a single header 134 // Test the cases with a single header
130 for (const auto& testCase : cases) { 135 for (const auto& testCase : cases) {
131 OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSiz e(500, 500)); 136 OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSiz e(500, 500));
132 dummyPageHolder->frame().settings()->setScriptEnabled(true); 137 dummyPageHolder->frame().settings()->setScriptEnabled(true);
133 OwnPtrWillBePersistent<MockLinkLoaderClient> loaderClient = MockLinkLoad erClient::create(testCase.linkLoaderShouldLoadValue); 138 OwnPtrWillBePersistent<MockLinkLoaderClient> loaderClient = MockLinkLoad erClient::create(testCase.linkLoaderShouldLoadValue);
134 OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(loaderClient. get()); 139 OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(loaderClient. get());
135 KURL hrefURL = KURL(KURL(), testCase.href); 140 KURL hrefURL = KURL(KURL(), testCase.href);
136 loader->loadLink(LinkRelAttribute("preload"), 141 loader->loadLink(LinkRelAttribute("preload"),
137 CrossOriginAttributeNotSet, 142 CrossOriginAttributeNotSet,
138 testCase.type, 143 testCase.type,
139 testCase.as, 144 testCase.as,
145 testCase.media,
140 hrefURL, 146 hrefURL,
141 dummyPageHolder->document(), 147 dummyPageHolder->document(),
142 NetworkHintsMock()); 148 NetworkHintsMock());
143 ASSERT(dummyPageHolder->document().fetcher()); 149 ASSERT(dummyPageHolder->document().fetcher());
144 WillBeHeapListHashSet<RefPtrWillBeMember<Resource>>* preloads = dummyPag eHolder->document().fetcher()->preloads(); 150 WillBeHeapListHashSet<RefPtrWillBeMember<Resource>>* preloads = dummyPag eHolder->document().fetcher()->preloads();
145 if (testCase.expectingLoad) { 151 if (testCase.expectingLoad) {
146 if (!preloads) 152 if (!preloads)
147 fprintf(stderr, "Unexpected result %s %s %s\n", testCase.href, t estCase.as, testCase.type); 153 fprintf(stderr, "Unexpected result %s %s %s\n", testCase.href, t estCase.as, testCase.type);
148 ASSERT_NE(nullptr, preloads); 154 ASSERT_NE(nullptr, preloads);
149 } else { 155 } else {
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSiz e(500, 500)); 191 OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSiz e(500, 500));
186 dummyPageHolder->document().settings()->setDNSPrefetchingEnabled(true); 192 dummyPageHolder->document().settings()->setDNSPrefetchingEnabled(true);
187 OwnPtrWillBePersistent<MockLinkLoaderClient> loaderClient = MockLinkLoad erClient::create(testCase.shouldLoad); 193 OwnPtrWillBePersistent<MockLinkLoaderClient> loaderClient = MockLinkLoad erClient::create(testCase.shouldLoad);
188 OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(loaderClient. get()); 194 OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(loaderClient. get());
189 KURL hrefURL = KURL(KURL(ParsedURLStringTag(), String("http://example.co m")), testCase.href); 195 KURL hrefURL = KURL(KURL(ParsedURLStringTag(), String("http://example.co m")), testCase.href);
190 NetworkHintsMock networkHints; 196 NetworkHintsMock networkHints;
191 loader->loadLink(LinkRelAttribute("dns-prefetch"), 197 loader->loadLink(LinkRelAttribute("dns-prefetch"),
192 CrossOriginAttributeNotSet, 198 CrossOriginAttributeNotSet,
193 String(), 199 String(),
194 String(), 200 String(),
201 String(),
195 hrefURL, 202 hrefURL,
196 dummyPageHolder->document(), 203 dummyPageHolder->document(),
197 networkHints); 204 networkHints);
198 ASSERT_FALSE(networkHints.didPreconnect()); 205 ASSERT_FALSE(networkHints.didPreconnect());
199 ASSERT_EQ(testCase.shouldLoad, networkHints.didDnsPrefetch()); 206 ASSERT_EQ(testCase.shouldLoad, networkHints.didDnsPrefetch());
200 } 207 }
201 } 208 }
202 209
203 TEST(LinkLoaderTest, Preconnect) 210 TEST(LinkLoaderTest, Preconnect)
204 { 211 {
(...skipping 14 matching lines...) Expand all
219 for (const auto& testCase : cases) { 226 for (const auto& testCase : cases) {
220 OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSiz e(500, 500)); 227 OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSiz e(500, 500));
221 OwnPtrWillBePersistent<MockLinkLoaderClient> loaderClient = MockLinkLoad erClient::create(testCase.shouldLoad); 228 OwnPtrWillBePersistent<MockLinkLoaderClient> loaderClient = MockLinkLoad erClient::create(testCase.shouldLoad);
222 OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(loaderClient. get()); 229 OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(loaderClient. get());
223 KURL hrefURL = KURL(KURL(ParsedURLStringTag(), String("http://example.co m")), testCase.href); 230 KURL hrefURL = KURL(KURL(ParsedURLStringTag(), String("http://example.co m")), testCase.href);
224 NetworkHintsMock networkHints; 231 NetworkHintsMock networkHints;
225 loader->loadLink(LinkRelAttribute("preconnect"), 232 loader->loadLink(LinkRelAttribute("preconnect"),
226 testCase.crossOrigin, 233 testCase.crossOrigin,
227 String(), 234 String(),
228 String(), 235 String(),
236 String(),
229 hrefURL, 237 hrefURL,
230 dummyPageHolder->document(), 238 dummyPageHolder->document(),
231 networkHints); 239 networkHints);
232 ASSERT_EQ(testCase.shouldLoad, networkHints.didPreconnect()); 240 ASSERT_EQ(testCase.shouldLoad, networkHints.didPreconnect());
233 ASSERT_EQ(testCase.isHTTPS, networkHints.isHTTPS()); 241 ASSERT_EQ(testCase.isHTTPS, networkHints.isHTTPS());
234 ASSERT_EQ(testCase.isCrossOrigin, networkHints.isCrossOrigin()); 242 ASSERT_EQ(testCase.isCrossOrigin, networkHints.isCrossOrigin());
235 } 243 }
236 } 244 }
237 245
238 } // namespace blink 246 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698