Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1738103002: Add type signatures for enums in wallpaper API. (Closed)

Created:
4 years, 10 months ago by ryoh
Modified:
4 years, 9 months ago
Reviewers:
fukino, Dan Beam
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, hirono
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add type signatures for enums in wallpaper API. We use enums instead of string directly, but I forgot to add enum type signatures for closure compiler. BUG=578935 Committed: https://crrev.com/07e06314d1e4cba78137fcea8bb374b168e1b632 Cr-Commit-Position: refs/heads/master@{#378174}

Patch Set 1 #

Patch Set 2 : copy and paste from upstream #

Total comments: 2

Patch Set 3 : remove leading spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M ui/file_manager/externs/chrome_wallpaper.js View 1 2 1 chunk +15 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
ryoh
Sorry, I forgot to add type signatures for enums even though I use an enum ...
4 years, 10 months ago (2016-02-26 09:17:21 UTC) #2
Dan Beam
lgtm
4 years, 10 months ago (2016-02-26 17:05:40 UTC) #4
ryoh
On 2016/02/26 17:05:40, Dan Beam wrote: > lgtm Thank you!
4 years, 9 months ago (2016-02-27 03:43:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738103002/1
4 years, 9 months ago (2016-02-27 03:43:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/151133)
4 years, 9 months ago (2016-02-27 03:55:24 UTC) #9
ryoh
> fukino@. I copied and pasted definitions from upstream externs file. Could you take a ...
4 years, 9 months ago (2016-02-29 05:50:00 UTC) #10
fukino
lgtm with a nit. https://codereview.chromium.org/1738103002/diff/20001/ui/file_manager/externs/chrome_wallpaper.js File ui/file_manager/externs/chrome_wallpaper.js (right): https://codereview.chromium.org/1738103002/diff/20001/ui/file_manager/externs/chrome_wallpaper.js#newcode10 ui/file_manager/externs/chrome_wallpaper.js:10: * @const nit: every line ...
4 years, 9 months ago (2016-02-29 05:51:43 UTC) #11
ryoh
https://codereview.chromium.org/1738103002/diff/20001/ui/file_manager/externs/chrome_wallpaper.js File ui/file_manager/externs/chrome_wallpaper.js (right): https://codereview.chromium.org/1738103002/diff/20001/ui/file_manager/externs/chrome_wallpaper.js#newcode10 ui/file_manager/externs/chrome_wallpaper.js:10: * @const On 2016/02/29 05:51:43, fukino wrote: > nit: ...
4 years, 9 months ago (2016-02-29 05:54:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738103002/40001
4 years, 9 months ago (2016-02-29 05:55:06 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-02-29 06:23:31 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 06:24:30 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/07e06314d1e4cba78137fcea8bb374b168e1b632
Cr-Commit-Position: refs/heads/master@{#378174}

Powered by Google App Engine
This is Rietveld 408576698