More general version of image filtering; reworked to be robust and easier to SSE

tests/PaintTest.cpp

Index: tests/PaintTest.cpp
diff --git a/tests/PaintTest.cpp b/tests/PaintTest.cpp
index 0db34b6f09a5730e05fc6926f13a1ff4704c5183..64cb77c78f5a7aed42ea3dd13561c9269e9b6e33 100644
--- a/tests/PaintTest.cpp
+++ b/tests/PaintTest.cpp
@@ -14,15 +14,15 @@
 // temparary api for bicubic, just be sure we can set/clear it
 static void test_bicubic(skiatest::Reporter* reporter) {
     SkPaint p0;
-    REPORTER_ASSERT(reporter, 0 == (p0.getFlags() & SkPaint::kBicubicFilterBitmap_Flag));
-    p0.setFlags(p0.getFlags() | SkPaint::kBicubicFilterBitmap_Flag);
-    REPORTER_ASSERT(reporter, 0 != (p0.getFlags() & SkPaint::kBicubicFilterBitmap_Flag));
+    REPORTER_ASSERT(reporter, 0 == (p0.getFlags() & SkPaint::kHighQualityFilterBitmap_Flag));

[reed1, 2013/06/18 20:21:21]

I suggest (in SkPaint.h) that this change is unnecessary.

[humper, 2013/06/19 20:49:26]

I made one an alias of the other, so I will revert the changes to the test.

+    p0.setFlags(p0.getFlags() | SkPaint::kHighQualityFilterBitmap_Flag);
+    REPORTER_ASSERT(reporter, 0 != (p0.getFlags() & SkPaint::kHighQualityFilterBitmap_Flag));
     SkPaint p1(p0);
-    REPORTER_ASSERT(reporter, 0 != (p1.getFlags() & SkPaint::kBicubicFilterBitmap_Flag));
+    REPORTER_ASSERT(reporter, 0 != (p1.getFlags() & SkPaint::kHighQualityFilterBitmap_Flag));
     p0.reset();
-    REPORTER_ASSERT(reporter, 0 == (p0.getFlags() & SkPaint::kBicubicFilterBitmap_Flag));
+    REPORTER_ASSERT(reporter, 0 == (p0.getFlags() & SkPaint::kHighQualityFilterBitmap_Flag));
     p0 = p1;
-    p0.setFlags(p0.getFlags() | SkPaint::kBicubicFilterBitmap_Flag);
+    p0.setFlags(p0.getFlags() | SkPaint::kHighQualityFilterBitmap_Flag);
 }
 
 static void test_copy(skiatest::Reporter* reporter) {