More general version of image filtering; reworked to be robust and easier to SSE

tests/PaintTest.cpp

 
 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #include "Test.h"
 #include "SkPath.h"
 #include "SkPaint.h"
 #include "SkLayerDrawLooper.h"
 #include "SkBlurMaskFilter.h"
 
 // temparary api for bicubic, just be sure we can set/clear it
 static void test_bicubic(skiatest::Reporter* reporter) {
     SkPaint p0;
-    REPORTER_ASSERT(reporter, 0 == (p0.getFlags() & SkPaint::kBicubicFilterBitmap_Flag));
-    p0.setFlags(p0.getFlags() | SkPaint::kBicubicFilterBitmap_Flag);
-    REPORTER_ASSERT(reporter, 0 != (p0.getFlags() & SkPaint::kBicubicFilterBitmap_Flag));
+    REPORTER_ASSERT(reporter, 0 == (p0.getFlags() & SkPaint::kHighQualityFilterBitmap_Flag));

[reed1, 2013/06/18 20:21:21]

I suggest (in SkPaint.h) that this change is unnecessary.

[humper, 2013/06/19 20:49:26]

I made one an alias of the other, so I will revert the changes to the test.

+    p0.setFlags(p0.getFlags() | SkPaint::kHighQualityFilterBitmap_Flag);
+    REPORTER_ASSERT(reporter, 0 != (p0.getFlags() & SkPaint::kHighQualityFilterBitmap_Flag));
     SkPaint p1(p0);
-    REPORTER_ASSERT(reporter, 0 != (p1.getFlags() & SkPaint::kBicubicFilterBitmap_Flag));
+    REPORTER_ASSERT(reporter, 0 != (p1.getFlags() & SkPaint::kHighQualityFilterBitmap_Flag));
     p0.reset();
-    REPORTER_ASSERT(reporter, 0 == (p0.getFlags() & SkPaint::kBicubicFilterBitmap_Flag));
+    REPORTER_ASSERT(reporter, 0 == (p0.getFlags() & SkPaint::kHighQualityFilterBitmap_Flag));
     p0 = p1;
-    p0.setFlags(p0.getFlags() | SkPaint::kBicubicFilterBitmap_Flag);
+    p0.setFlags(p0.getFlags() | SkPaint::kHighQualityFilterBitmap_Flag);
 }
 
 static void test_copy(skiatest::Reporter* reporter) {
     SkPaint paint;
     // set a few member variables
     paint.setStyle(SkPaint::kStrokeAndFill_Style);
     paint.setTextAlign(SkPaint::kLeft_Align);
     paint.setStrokeWidth(SkIntToScalar(2));
     // set a few pointers
     SkLayerDrawLooper* looper = new SkLayerDrawLooper();
@@ skipping 95 matching lines @@
 
     // regression tests
     regression_cubic(reporter);
     regression_measureText(reporter);
 
     test_bicubic(reporter);
 }
 
 #include "TestClassDef.h"
 DEFINE_TESTCLASS("Paint", TestPaintClass, TestPaint)