Issue 17381007: EME: ProxyDecryptor creates MediaKeys instead of Decryptor.

Issue 17381007: EME: ProxyDecryptor creates MediaKeys instead of Decryptor. (Closed)

Created:
7 years, 6 months ago by xhwang

Modified:
7 years, 6 months ago

Reviewers:
ddorwin

CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

EME: ProxyDecryptor creates MediaKeys instead of Decryptor. ProxyDecryptor will be the MediaKeys manager for EME v0.1b. So it'll create and manage MediaKeys instead of Decryptors. Also add GetDecryptor() method in MediaKey interface so that we can get a Decryptor through the MediaKeys interface. BUG=163552 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207233

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : rebase again #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -40 lines)			Patch
M	media/base/decryptor.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	media/base/media_keys.h	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	media/base/media_keys.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	media/base/mock_filters.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	media/crypto/aes_decryptor.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	media/crypto/aes_decryptor.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/renderer/media/crypto/ppapi_decryptor.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/renderer/media/crypto/ppapi_decryptor.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/renderer/media/crypto/proxy_decryptor.h	View	1 2	2 chunks	+6 lines, -5 lines	0 comments	Download
M	webkit/renderer/media/crypto/proxy_decryptor.cc	View	1 2	7 chunks	+19 lines, -23 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ddorwin

lgtm Descriptions suggestion: EME: ProxyDecryptor creates MediaKeys instead of Decryptor. ProxyDecryptor will be the MediaKeys ...

7 years, 6 months ago (2013-06-19 00:14:35 UTC) #2

xhwang

https://codereview.chromium.org/17381007/diff/2001/webkit/renderer/media/crypto/proxy_decryptor.h File webkit/renderer/media/crypto/proxy_decryptor.h (right): https://codereview.chromium.org/17381007/diff/2001/webkit/renderer/media/crypto/proxy_decryptor.h#newcode61 webkit/renderer/media/crypto/proxy_decryptor.h:61: scoped_ptr<media::MediaKeys> CreatePpapiDecryptor( On 2013/06/19 00:14:35, ddorwin wrote: > "Decryptor" ...

7 years, 6 months ago (2013-06-19 04:28:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/17381007/19001

7 years, 6 months ago (2013-06-19 04:55:11 UTC) #4

Message was sent while issue was closed.

Change committed as 207233

Expand Messages | Collapse Messages